From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config") Date: Tue, 10 Oct 2017 17:18:46 +0200 Message-ID: <20171010171846.509f399e@karo-electronics.de> References: <20171004103657.1c6a433d@karo-electronics.de> <1507646944.2398.1.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from smtprelay05.ispgateway.de (smtprelay05.ispgateway.de [80.67.18.28]) by alsa0.perex.cz (Postfix) with ESMTP id EDA5B266B38 for ; Tue, 10 Oct 2017 17:18:49 +0200 (CEST) In-Reply-To: <1507646944.2398.1.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lucas Stach Cc: alsa-devel@alsa-project.org, Mark Brown , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org SGksCgpPbiBUdWUsIDEwIE9jdCAyMDE3IDE2OjQ5OjA0ICswMjAwIEx1Y2FzIFN0YWNoIHdyb3Rl Ogo+IEhpIExvdGhhciwKPiAKPiBBbSBNaXR0d29jaCwgZGVuIDA0LjEwLjIwMTcsIDEwOjM2ICsw MjAwIHNjaHJpZWIgTG90aGFyIFdhw59tYW5uOgo+ID4gSGksCj4gPiAKPiA+IHRoZSBjb21taXQg NzBkNDM1YmExY2Q2ICgiQVNvQzogaW14LXBjbS1kbWE6IHNpbXBsaWZ5IHBjbV9jb25maWciKQo+ ID4gaW50cm9kdWNlZCBhIHJlZ3Jlc3Npb24gb24gdGhlIEthLVJvIFRYIHNlcmllcyBtb2R1bGVz IChhbmQgcG9zc2libHkKPiA+IG90aGVyIGhhcmR3YXJlIGFzIHdlbGwpLgo+ID4gCj4gPiBUaGUg cHJvYmxlbSBpcywgdGhhdCB0aGlzIGNvbW1pdCByZXN0cmljdHMgdGhlIHN1cHBvcnRlZCBzb3Vu ZAo+ID4gZm9ybWF0cwo+ID4gdG8gUzI0X0xFIG9ubHkgcmF0aGVyIHRoYW4gUzE2X0xFLCBTMjRf TEUsIFMyMF8zTEUgd2l0aG91dCB0aGUKPiA+IHBhdGNoLiBUaGVyZWZvcmUgYXBsYXkgZmFpbHMg d2l0aCB0aGUgZm9sbG93aW5nIGVycm9yIG1lc3NhZ2VzLCB3aGVuCj4gPiB0cnlpbmcgdG8gcGxh eSBhIHNvdW5kIGZpbGUgd2l0aCBTMTZfTEUgZm9ybWF0Ogo+ID4gPiBBTFNBIGxpYiBhbHNhLWxp Yi0KPiA+ID4gMS4xLjIvc3JjL3BjbS9wY21fcGFyYW1zLmM6MjE2Mjooc25kMV9wY21faHdfcmVm aW5lX3NsYXZlKSBTbGF2ZQo+ID4gPiBQQ00gbm90IHVzYWJsZQo+ID4gPiBhcGxheTogc2V0X3Bh cmFtczoxMjA0OiBCcm9rZW4gY29uZmlndXJhdGlvbiBmb3IgdGhpcyBQQ006IG5vCj4gPiA+IGNv bmZpZ3VyYXRpb25zIGF2YWlsYWJsZQo+ID4gCj4gPiBUaGlzIGlzIHdpdGggdGhlIHNpbXBsZS1z b3VuZC1jYXJkIGRyaXZlciBhcyB3ZWxsIGFzIHRoZSBpbXgtc2d0bDUwMDAKPiA+IGRyaXZlci4K PiA+IAo+ID4gQ2FuIHNvbWVvbmUgdGVsbCBtZSBvbiB3aGF0IGhhcmR3YXJlIGFuZCB3aXRoIHdo YXQgc29mdHdhcmUgaGFzIHRoaXMKPiA+IHBhdGNoIGJlZW4gdGVzdGVkPwo+IAo+IE15IHByaW1h cnkgdGVzdCBoYXJkd2FyZSB3YXMgdGhlIHppaS1yZHUyIGJvYXJkLCB0aGUgRFRTIGZvciB0aGlz IGJvYXJkCj4gY2FuIGJlIGZvdW5kIGluIHJlY2VudCBtYWlubGluZSBrZXJuZWxzLgo+IAo+IFVz ZXJzcGFjZSBpcyBiYXNlZCBvbiBwdWxzZWF1ZGlvLCB3aGljaCBtYXkgbWFzayB0aGUgcmVncmVz c2lvbiBieQo+IHJlc2FtcGxpbmcgdG8gdGhlIHN1cHBvcnRlZCBmb3JtYXQuIFNvcnJ5IGFib3V0 IHRoYXQuCj4gCj4gRnJvbSBteSB1bmRlcnN0YW5kaW5nIG9mIHRoZSBjb2RlLCBpdCBzaG91bGQg YmUgcG9zc2libGUgdG8gZml4IHRoZQo+IHJlZ3Jlc3Npb24gd2l0aG91dCByZXZlcnRpbmcgdGhp cyBwYXRjaCBieSBzZXR0aW5nCj4gU05EX0RNQUVOR0lORV9QQ01fREFJX0ZMQUdfUEFDSyBpbiB0 aGUgZmxhZ3MgZmllbGQgb2YgdGhlIERNQSBwYXJhbXMgaW4KPiBmc2xfc3NpLgo+IApJIHRyaWVk IHRoYXQsIGJ1dCB0aGVuIEkgZ2V0IERNQSB0aW1lb3V0cy4KCkkgY2lyY3VtdmVudGVkIHRoZSBw cm9ibGVtIGJ5IGNoYW5naW5nIG15IC9ldGMvYXNvdW5kLmNvbmYgdG8gdXNlIHRoZQpvbmx5IHN1 cHBvcnRlZCBzYW1wbGUgZm9ybWF0LiBTbywgaWYgbm9ib2R5IGVsc2UgaGFzIGEgcHJvYmxlbSwg dGhlcmUKaXMgbm8gbmVlZCB0byByZXZlcnQgdGhlIHBhdGNoIG9yIGFwcGx5IGFkZGl0aW9uYWwg bW9kaWZpY2F0aW9ucyB0byB0aGUKZHJpdmVyLgoKCkxvdGhhciBXYcOfbWFubgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpBbHNhLWRldmVsIG1haWxpbmcg bGlzdApBbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKaHR0cDovL21haWxtYW4uYWxzYS1wcm9q ZWN0Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: LW@KARO-electronics.de (Lothar =?UTF-8?B?V2HDn21hbm4=?=) Date: Tue, 10 Oct 2017 17:18:46 +0200 Subject: regression introduced by commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config") In-Reply-To: <1507646944.2398.1.camel@pengutronix.de> References: <20171004103657.1c6a433d@karo-electronics.de> <1507646944.2398.1.camel@pengutronix.de> Message-ID: <20171010171846.509f399e@karo-electronics.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Tue, 10 Oct 2017 16:49:04 +0200 Lucas Stach wrote: > Hi Lothar, > > Am Mittwoch, den 04.10.2017, 10:36 +0200 schrieb Lothar Wa?mann: > > Hi, > > > > the commit 70d435ba1cd6 ("ASoC: imx-pcm-dma: simplify pcm_config") > > introduced a regression on the Ka-Ro TX series modules (and possibly > > other hardware as well). > > > > The problem is, that this commit restricts the supported sound > > formats > > to S24_LE only rather than S16_LE, S24_LE, S20_3LE without the > > patch. Therefore aplay fails with the following error messages, when > > trying to play a sound file with S16_LE format: > > > ALSA lib alsa-lib- > > > 1.1.2/src/pcm/pcm_params.c:2162:(snd1_pcm_hw_refine_slave) Slave > > > PCM not usable > > > aplay: set_params:1204: Broken configuration for this PCM: no > > > configurations available > > > > This is with the simple-sound-card driver as well as the imx-sgtl5000 > > driver. > > > > Can someone tell me on what hardware and with what software has this > > patch been tested? > > My primary test hardware was the zii-rdu2 board, the DTS for this board > can be found in recent mainline kernels. > > Userspace is based on pulseaudio, which may mask the regression by > resampling to the supported format. Sorry about that. > > From my understanding of the code, it should be possible to fix the > regression without reverting this patch by setting > SND_DMAENGINE_PCM_DAI_FLAG_PACK in the flags field of the DMA params in > fsl_ssi. > I tried that, but then I get DMA timeouts. I circumvented the problem by changing my /etc/asound.conf to use the only supported sample format. So, if nobody else has a problem, there is no need to revert the patch or apply additional modifications to the driver. Lothar Wa?mann