All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	ldv-project@linuxtesting.org
Subject: Re: [PATCH] rpmsg: glink: keep balance of mutex locks in qcom_glink_request_intent()
Date: Tue, 10 Oct 2017 11:26:38 -0700	[thread overview]
Message-ID: <20171010182638.GL20643@builder> (raw)
In-Reply-To: <1507325037-20889-1-git-send-email-khoroshilov@ispras.ru>

On Fri 06 Oct 14:23 PDT 2017, Alexey Khoroshilov wrote:

> If qcom_glink_tx() fails in qcom_glink_request_intent(),
> it returns immediately leaving intent_req_lock mutex locked.
> So the next tries to send intent request lead to deadlock.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>

Thanks Alexey.

This was found by Dan Carpenter a few weeks ago, but I failed to send
the pull request for it, will do so now.

Regards,
Bjorn

      reply	other threads:[~2017-10-10 18:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 21:23 [PATCH] rpmsg: glink: keep balance of mutex locks in qcom_glink_request_intent() Alexey Khoroshilov
2017-10-10 18:26 ` Bjorn Andersson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171010182638.GL20643@builder \
    --to=bjorn.andersson@linaro.org \
    --cc=khoroshilov@ispras.ru \
    --cc=ldv-project@linuxtesting.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.