From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
suravee.suthikulpanit@amd.com
Subject: Re: [PATCH] KVM: SVM: unconditionally wake up VCPU on IOMMU interrupt
Date: Tue, 10 Oct 2017 21:17:17 +0200 [thread overview]
Message-ID: <20171010191716.GD28763@flask> (raw)
In-Reply-To: <1507633049-63191-1-git-send-email-pbonzini@redhat.com>
2017-10-10 12:57+0200, Paolo Bonzini:
> Checking the mode is unnecessary, and is done without a memory barrier
> separating the LAPIC write from the vcpu->mode read; in addition,
> kvm_vcpu_wake_up is already doing a check for waiters on the wait queue
> that has the same effect.
>
> In practice it's safe because spin_lock has full-barrier semantics on x86,
> but don't be too clever.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
prev parent reply other threads:[~2017-10-10 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 10:57 [PATCH] KVM: SVM: unconditionally wake up VCPU on IOMMU interrupt Paolo Bonzini
2017-10-10 19:17 ` Radim Krčmář [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171010191716.GD28763@flask \
--to=rkrcmar@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.