All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: dri-devel@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	gregkh@linuxfoundation.org,
	outreachy-kernel <outreachy-kernel@googlegroups.com>,
	Sean Paul <seanpaul@chromium.org>,
	Eric Engestrom <eric.engestrom@imgtec.com>
Subject: Re: [PATCH 1/2] drm: Extract drm_debug.[hc]
Date: Wed, 11 Oct 2017 13:12:50 +0300	[thread overview]
Message-ID: <20171011101250.GW10981@intel.com> (raw)
In-Reply-To: <830fcacb4513dc2ca7f44cb1828d8cfa0e4e15ae.1507693829.git.hamohammed.sa@gmail.com>

On Tue, Oct 10, 2017 at 10:13:36PM -0600, Haneen Mohammed wrote:
> -/**
> - * Debug output.
> - *
> - * \param fmt printf() like format string.
> - * \param arg arguments
> - */
> -#define DRM_DEV_DEBUG(dev, fmt, args...)				\
> -	drm_dev_printk(dev, KERN_DEBUG, DRM_UT_CORE, __func__, "", fmt,	\
> -		       ##args)

BTW if you're poking around these parts maybe you might consider undoing
the damage from c4e68a583202 ("drm: Introduce DRM_DEV_* log messages")
and restoing the 'if (unlikely(drm_debug & DRM_UT_...)' into the debug
macros. Currently we're paying the cost of the function call for every
debug statement even when debugs are disabled.

-- 
Ville Syrj�l�
Intel OTC


WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Haneen Mohammed <hamohammed.sa@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	outreachy-kernel <outreachy-kernel@googlegroups.com>,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/2] drm: Extract drm_debug.[hc]
Date: Wed, 11 Oct 2017 13:12:50 +0300	[thread overview]
Message-ID: <20171011101250.GW10981@intel.com> (raw)
In-Reply-To: <830fcacb4513dc2ca7f44cb1828d8cfa0e4e15ae.1507693829.git.hamohammed.sa@gmail.com>

On Tue, Oct 10, 2017 at 10:13:36PM -0600, Haneen Mohammed wrote:
> -/**
> - * Debug output.
> - *
> - * \param fmt printf() like format string.
> - * \param arg arguments
> - */
> -#define DRM_DEV_DEBUG(dev, fmt, args...)				\
> -	drm_dev_printk(dev, KERN_DEBUG, DRM_UT_CORE, __func__, "", fmt,	\
> -		       ##args)

BTW if you're poking around these parts maybe you might consider undoing
the damage from c4e68a583202 ("drm: Introduce DRM_DEV_* log messages")
and restoing the 'if (unlikely(drm_debug & DRM_UT_...)' into the debug
macros. Currently we're paying the cost of the function call for every
debug statement even when debugs are disabled.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-10-11 10:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1507693829.git.hamohammed.sa@gmail.com>
2017-10-11  4:13 ` [PATCH 1/2] drm: Extract drm_debug.[hc] Haneen Mohammed
2017-10-11  4:13   ` Haneen Mohammed
2017-10-11 10:12   ` Ville Syrjälä [this message]
2017-10-11 10:12     ` Ville Syrjälä
2017-10-11 11:40   ` Daniel Vetter
2017-10-11 11:40     ` Daniel Vetter
2017-10-11 21:55     ` Haneen Mohammed
2017-10-11 21:55       ` Haneen Mohammed
2017-10-12 23:32   ` kbuild test robot
2017-10-12 23:32     ` kbuild test robot
2017-10-11  4:16 ` [PATCH 2/2] drm: Update old comment style Haneen Mohammed
2017-10-11  4:16   ` Haneen Mohammed
2017-10-11 11:42   ` Daniel Vetter
2017-10-11 11:42     ` Daniel Vetter
2017-10-13  0:40   ` kbuild test robot
2017-10-13  0:40     ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171011101250.GW10981@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric.engestrom@imgtec.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=seanpaul@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.