From: Tomasz Duszynski <tdu@semihalf.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
Tomasz Duszynski <tdu@semihalf.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] crypto: use snprintf return value correctly
Date: Wed, 11 Oct 2017 12:42:15 +0200 [thread overview]
Message-ID: <20171011104215.GA14608@tdu> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC2FF8F@IRSMSX108.ger.corp.intel.com>
On Wed, Oct 11, 2017 at 10:09:02AM +0000, De Lara Guarch, Pablo wrote:
> Hi,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> > Sent: Wednesday, October 11, 2017 10:58 AM
> > To: Tomasz Duszynski <tdu@semihalf.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] crypto: use snprintf return value correctly
> >
> > On Wed, Oct 11, 2017 at 11:25:40AM +0200, Tomasz Duszynski wrote:
> > > snprintf return value is the length of was encoded into destination
> > > array excluding '\0'. Thus return value equal to the length of the
> > > destination array or more means truncation.
> > >
> > > This commit fixes improper use of the return value.
> > >
> > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > > ---
> > Good catch.
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Since this is a fix, you should add Fixes lines (one per PMD), and CC stable.
>
> Thanks!
> Pablo
>
ACK
--
- Tomasz Duszyński
next prev parent reply other threads:[~2017-10-11 10:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 9:25 [PATCH] crypto: use snprintf return value correctly Tomasz Duszynski
2017-10-11 9:58 ` Bruce Richardson
2017-10-11 10:09 ` De Lara Guarch, Pablo
2017-10-11 10:42 ` Tomasz Duszynski [this message]
2017-10-11 11:05 ` [PATCH v2] " Tomasz Duszynski
2017-10-12 8:03 ` [dpdk-stable] " De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011104215.GA14608@tdu \
--to=tdu@semihalf.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.