From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:48312 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751991AbdJKMvp (ORCPT
        <rfc822;stable@vger.kernel.org>); Wed, 11 Oct 2017 08:51:45 -0400
Date: Wed, 11 Oct 2017 14:51:53 +0200
From: Greg KH <greg@kroah.com>
To: Johan Hovold <johan@kernel.org>
Cc: linux-usb@vger.kernel.org, stable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/5] USB: serial: garmin_gps: fix I/O after failed probe
 and remove
Message-ID: <20171011125153.GA27734@kroah.com>
References: <20171011120301.25673-1-johan@kernel.org>
 <20171011120301.25673-2-johan@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20171011120301.25673-2-johan@kernel.org>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Oct 11, 2017 at 02:02:57PM +0200, Johan Hovold wrote:
> Make sure to stop any submitted interrupt and bulk-out URBs before
> returning after failed probe and when the port is being unbound to avoid
> later NULL-pointer dereferences in the completion callbacks.
> 
> Also fix up the related and broken I/O cancellation on failed open and
> on close. (Note that port->write_urb was never submitted.)
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Cc: stable <stable@vger.kernel.org>	# 51a2f077 ("USB: introduce usb_anchor")
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>