From: Greg KH <gregkh@linuxfoundation.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Andrey Konovalov <andreyknvl@google.com>,
alsa-devel@alsa-project.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 0/9] sound: Add sanity checks for invalid EPs
Date: Wed, 11 Oct 2017 15:03:29 +0200 [thread overview]
Message-ID: <20171011130329.GI27734@kroah.com> (raw)
In-Reply-To: <20171011103646.11879-1-tiwai@suse.de>
On Wed, Oct 11, 2017 at 12:36:37PM +0200, Takashi Iwai wrote:
> Hi,
>
> this is a revised patch set to cover the codes that may submit URBs
> containing invalid EPs without validation, which result in the kernel
> warning from the USB core. The first patch adds a new helper for
> simplifying the EP check, and the rest applies it at needed places.
>
> The original issues were spotted by syzkaller, and I put a few others
> for covering more similar cases.
>
> The only updated code in v2 is about the first patch to add
> usb_urb_ep_type_check() helper (in addition to tested-by tag from
> Andrey). Typos were fixed and it's called also from usb_submit_urb()
> as Greg suggested, too.
>
> USB devs: does this look OK now?
>
> If yes, and if I get acks, I can take the patches to sound tree. Or I
> don't mind if you take all to usb tree, too. Or maybe better, I'll
> prepare an immutable branch based on 4.4.14-rc (rc4 for now) in case
> you want to pull into both trees. Let me know your wish.
Whole series looks good to me, feel free to take them in your tree if
that's the easiest:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
No need for a branch, merges in this area should be rare...
thanks,
greg k-h
next prev parent reply other threads:[~2017-10-11 13:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 10:36 [PATCH v2 0/9] sound: Add sanity checks for invalid EPs Takashi Iwai
[not found] ` <20171011103646.11879-1-tiwai-l3A5Bk7waGM@public.gmane.org>
2017-10-11 10:36 ` [PATCH v2 1/9] usb: core: Add a helper function to check the validity of EP type in URB Takashi Iwai
2017-10-11 14:14 ` Johan Hovold
2017-10-11 14:31 ` Takashi Iwai
[not found] ` <s5hbmld92ok.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2017-10-11 14:58 ` Johan Hovold
2017-10-11 10:36 ` [PATCH v2 2/9] ALSA: bcd2000: Add a sanity check for invalid EPs Takashi Iwai
2017-10-11 10:36 ` [PATCH v2 3/9] ALSA: caiaq: " Takashi Iwai
2017-10-11 14:20 ` Johan Hovold
2017-10-11 14:40 ` Takashi Iwai
[not found] ` <s5ha80x928r.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2017-10-11 14:49 ` Johan Hovold
2017-10-11 15:05 ` Takashi Iwai
2017-10-11 10:36 ` [PATCH v2 4/9] ALSA: line6: " Takashi Iwai
2017-10-11 14:28 ` Johan Hovold
2017-10-11 14:45 ` Takashi Iwai
[not found] ` <s5h7ew1920z.wl-tiwai-l3A5Bk7waGM@public.gmane.org>
2017-10-11 14:52 ` Johan Hovold
2017-10-11 14:58 ` Takashi Iwai
2017-10-11 10:36 ` [PATCH v2 5/9] ALSA: usb-audio: Add sanity checks " Takashi Iwai
2017-10-11 10:36 ` [PATCH v2 7/9] ALSA: hiface: " Takashi Iwai
2017-10-11 10:36 ` [PATCH v2 8/9] ALSA: caiaq: Add yet more " Takashi Iwai
2017-10-11 10:36 ` [PATCH v2 9/9] ALSA: line6: " Takashi Iwai
[not found] ` <20171011103646.11879-10-tiwai-l3A5Bk7waGM@public.gmane.org>
2017-10-11 14:39 ` Johan Hovold
2017-10-11 14:48 ` Takashi Iwai
2017-10-11 10:36 ` [PATCH v2 6/9] ALSA: usx2y: Add " Takashi Iwai
[not found] ` <20171011103646.11879-7-tiwai-l3A5Bk7waGM@public.gmane.org>
2017-10-11 14:33 ` Johan Hovold
2017-10-11 14:43 ` Takashi Iwai
2017-10-11 13:03 ` Greg KH [this message]
[not found] ` <20171011130329.GI27734-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-10-11 13:15 ` [PATCH v2 0/9] sound: " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011130329.GI27734@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=andreyknvl@google.com \
--cc=linux-usb@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.