From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f65.google.com ([209.85.215.65]:52740 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752488AbdJKN1Z (ORCPT ); Wed, 11 Oct 2017 09:27:25 -0400 Date: Wed, 11 Oct 2017 15:27:25 +0200 From: Johan Hovold To: Greg KH Cc: Johan Hovold , linux-usb@vger.kernel.org, stable Subject: Re: [PATCH 1/5] USB: serial: garmin_gps: fix I/O after failed probe and remove Message-ID: <20171011132725.GV4269@localhost> References: <20171011120301.25673-1-johan@kernel.org> <20171011120301.25673-2-johan@kernel.org> <20171011125153.GA27734@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171011125153.GA27734@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Oct 11, 2017 at 02:51:53PM +0200, Greg Kroah-Hartman wrote: > On Wed, Oct 11, 2017 at 02:02:57PM +0200, Johan Hovold wrote: > > Make sure to stop any submitted interrupt and bulk-out URBs before > > returning after failed probe and when the port is being unbound to avoid > > later NULL-pointer dereferences in the completion callbacks. > > > > Also fix up the related and broken I/O cancellation on failed open and > > on close. (Note that port->write_urb was never submitted.) > > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > Cc: stable # 51a2f077 ("USB: introduce usb_anchor") > > Signed-off-by: Johan Hovold > > Reviewed-by: Greg Kroah-Hartman Thanks for reviewing these. All now applied. Johan