From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Wed, 11 Oct 2017 14:55:17 +0100 Subject: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events In-Reply-To: <20171011132431.GL17961@rric.localdomain> References: <20170824120349.2323-1-ganapatrao.kulkarni@cavium.com> <20170824120349.2323-5-ganapatrao.kulkarni@cavium.com> <43dcc107-263a-5429-73d4-a5290c6610d6@hisilicon.com> <20170829124730.GH17961@rric.localdomain> <20171011121926.GC11106@arm.com> <20171011132431.GL17961@rric.localdomain> Message-ID: <20171011135517.GF11106@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Oct 11, 2017 at 03:24:31PM +0200, Robert Richter wrote: > On 11.10.17 13:19:27, Will Deacon wrote: > > On Tue, Aug 29, 2017 at 02:47:30PM +0200, Robert Richter wrote: > > > Shaokun, > > > > > > On 29.08.17 17:26:00, Zhangshaokun wrote: > > > > On 2017/8/24 20:03, Ganapatrao Kulkarni wrote: > > > > > This is not a full event list, but a short list of useful events. > > > > > > > > > > Signed-off-by: Ganapatrao Kulkarni > > > > > --- > > > > > tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++ > > > > > .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++ > > > > > 2 files changed, 77 insertions(+) > > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv > > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json > > > > > > > > > > > > > I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion > > > > that would use vendor sub-folder? > > > > Of course, appreciate maintainer's comments. > > > > > > this would just add another level of subdirectories. I rather would > > > prefer to have a per platform dir comparable to what is listed in > > > > > > arch/arm64/Kconfig.platforms > > > > > > This is the same as Ganapat has implemented it. > > > > FWIW, I agree with Zhangshaokun here that a silicon vendor subdirectory > > would organise things better. It also matches what we do for > > arch/arm64/boot/dts/ > > A file structure like: > > tools/perf/pmu-events/arch/arm64/cavium/thunderx2/implementation-defined.json > > looks quite horible. In contrast to dts dir we will need another > subdir for each platform and will then have two levels of subdirs. In which case, call the file thunderx2-imp-def.json or something. The advantage then is that the SoC names are namespaced by vendor, which is the best way to avoid confusion imo. Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757718AbdJKNzQ (ORCPT ); Wed, 11 Oct 2017 09:55:16 -0400 Received: from foss.arm.com ([217.140.101.70]:33034 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757616AbdJKNzO (ORCPT ); Wed, 11 Oct 2017 09:55:14 -0400 Date: Wed, 11 Oct 2017 14:55:17 +0100 From: Will Deacon To: Robert Richter Cc: Zhangshaokun , Ganapatrao Kulkarni , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, mark.rutland@arm.com, acme@kernel.org, alexander.shishkin@linux.intel.com, peterz@infradead.org, mingo@redhat.com, jnair@caviumnetworks.com, Jonathan.Cameron@huawei.com, gklkml16@gmail.com Subject: Re: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events Message-ID: <20171011135517.GF11106@arm.com> References: <20170824120349.2323-1-ganapatrao.kulkarni@cavium.com> <20170824120349.2323-5-ganapatrao.kulkarni@cavium.com> <43dcc107-263a-5429-73d4-a5290c6610d6@hisilicon.com> <20170829124730.GH17961@rric.localdomain> <20171011121926.GC11106@arm.com> <20171011132431.GL17961@rric.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171011132431.GL17961@rric.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 11, 2017 at 03:24:31PM +0200, Robert Richter wrote: > On 11.10.17 13:19:27, Will Deacon wrote: > > On Tue, Aug 29, 2017 at 02:47:30PM +0200, Robert Richter wrote: > > > Shaokun, > > > > > > On 29.08.17 17:26:00, Zhangshaokun wrote: > > > > On 2017/8/24 20:03, Ganapatrao Kulkarni wrote: > > > > > This is not a full event list, but a short list of useful events. > > > > > > > > > > Signed-off-by: Ganapatrao Kulkarni > > > > > --- > > > > > tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++ > > > > > .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++ > > > > > 2 files changed, 77 insertions(+) > > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv > > > > > create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json > > > > > > > > > > > > > I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion > > > > that would use vendor sub-folder? > > > > Of course, appreciate maintainer's comments. > > > > > > this would just add another level of subdirectories. I rather would > > > prefer to have a per platform dir comparable to what is listed in > > > > > > arch/arm64/Kconfig.platforms > > > > > > This is the same as Ganapat has implemented it. > > > > FWIW, I agree with Zhangshaokun here that a silicon vendor subdirectory > > would organise things better. It also matches what we do for > > arch/arm64/boot/dts/ > > A file structure like: > > tools/perf/pmu-events/arch/arm64/cavium/thunderx2/implementation-defined.json > > looks quite horible. In contrast to dts dir we will need another > subdir for each platform and will then have two levels of subdirs. In which case, call the file thunderx2-imp-def.json or something. The advantage then is that the SoC names are namespaced by vendor, which is the best way to avoid confusion imo. Will