From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH v9 3/3] tools/libxc: use superpages during
 restore of HVM guest
Date: Wed, 11 Oct 2017 17:09:43 +0200
Message-ID: <20171011150943.GK4226@aepfle.de>
References: <20170901160843.9057-1-olaf@aepfle.de>
 <20170901160843.9057-4-olaf@aepfle.de>
 <20170906113410.2upxmdambiwzvk5g@citrix.com>
 <4623274e-c8fe-e9ad-67bb-c42e1e85c1ef@citrix.com>
 <20170908114536.GD19889@aepfle.de>
 <20171011141532.GI4226@aepfle.de>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8109910691295875656=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20171011141532.GI4226@aepfle.de>
List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
 <mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Errors-To: xen-devel-bounces@lists.xen.org
Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org


--===============8109910691295875656==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="45wMVEkw4XUbiYON"
Content-Disposition: inline


--45wMVEkw4XUbiYON
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On Wed, Oct 11, Olaf Hering wrote:

> -#define MAX_BATCH_SIZE 1024   /* up to 1024 pages (4MB) at a time */
> +#define MAX_BATCH_SIZE SUPERPAGE_1GB_NR_PFNS   /* up to 1GB at a time */

Actually the error is something else, I missed this in the debug output:

xc: error: Failed to get types for pfn batch (7 = Argument list too long): Internal error

write_batch() should probably split the requests when filling types[] because
Xen has "1024" hardcoded in XEN_DOMCTL_getpageframeinfo3...


Olaf

--45wMVEkw4XUbiYON
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EARECAB0WIQSkRyP6Rn//f03pRUBdQqD6ppg2fgUCWd40NAAKCRBdQqD6ppg2
fixDAJ0V4gKW2sHPTAqLy294KvqTqZzaegCZAQeDqeI+2+Dg4/9U0ESA5ABVIzg=
=XYPD
-----END PGP SIGNATURE-----

--45wMVEkw4XUbiYON--


--===============8109910691295875656==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs
IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v
cmcveGVuLWRldmVsCg==

--===============8109910691295875656==--