From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Allow PCH platforms fall back to BIOS LVDS mode
Date: Wed, 11 Oct 2017 21:47:36 +0300 [thread overview]
Message-ID: <20171011184736.GC10981@intel.com> (raw)
In-Reply-To: <150774520576.26842.17849502344588841053@mail.alporthouse.com>
On Wed, Oct 11, 2017 at 07:06:45PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2017-10-09 17:19:51)
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > With intel_encoder_current_mode() using the normal state readout code it
> > actually works on PCH platforms as well. So let's nuke the PCH check from
> > intel_lvds_init(). I suppose there aren't any machines that actually
> > need this, but at least we get to eliminate a few lines of code, and one
> > FIXME.
> >
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> I have to admit the FIXME comment confused me utterly.
It does seem to be something not quite English.
> Having read the
> function, this should now work given the conversion of
> intel_encoder_current_mode() to use the common encoder->get_hw_state()
> routine.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Thanks. Pushed this one as well.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-10-11 18:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 16:19 [PATCH 1/2] drm/i915: Reuse normal state readout for LVDS/DVO fixed mode Ville Syrjala
2017-10-09 16:19 ` [PATCH 2/2] drm/i915: Allow PCH platforms fall back to BIOS LVDS mode Ville Syrjala
2017-10-11 18:06 ` Chris Wilson
2017-10-11 18:47 ` Ville Syrjälä [this message]
2017-10-09 17:00 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Reuse normal state readout for LVDS/DVO fixed mode Patchwork
2017-10-09 21:39 ` ✓ Fi.CI.IGT: " Patchwork
2017-10-10 14:33 ` [PATCH 1/2] " Chris Wilson
2017-10-10 14:55 ` Ville Syrjälä
2017-10-11 16:21 ` Chris Wilson
2017-10-11 17:18 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011184736.GC10981@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.