From: Stephen Boyd <sboyd@codeaurora.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org, Viresh Kumar <vireshk@kernel.org>,
Nishanth Menon <nm@ti.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Subject: Re: [PATCH v2] PM / OPP: add missing of_node_put() for of_get_cpu_node()
Date: Wed, 11 Oct 2017 13:20:22 -0700 [thread overview]
Message-ID: <20171011202011.GB25302@codeaurora.org> (raw)
In-Reply-To: <1507716661-27146-1-git-send-email-sudeep.holla@arm.com>
On 10/11, Sudeep Holla wrote:
> @@ -603,7 +603,7 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev,
> @@ -614,10 +614,12 @@ int dev_pm_opp_of_get_sharing_cpus(struct device *cpu_dev,
> /* Get OPP descriptor node */
> tmp_np = _opp_of_get_opp_desc_node(cpu_np);
> if (!tmp_np) {
> + of_node_put(cpu_np);
> pr_err("%pOF: Couldn't find opp node\n", cpu_np);
> ret = -ENOENT;
> goto put_cpu_node;
> }
> + of_node_put(cpu_np);
>
Why not?
tmp_np = _opp_of_get_opp_desc_node(cpu_np);
of_node_put(cpu_np);
if (!tmp_np) {
pr_err("%pOF: Couldn't find opp node\n", cpu_np);
ret = -ENOENT;
goto put_cpu_node;
}
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-10-11 20:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-10 10:48 [PATCH] PM / OPP: use of_cpu_device_node_get() instead of of_get_cpu_node() Sudeep Holla
2017-10-10 11:45 ` Viresh Kumar
2017-10-10 12:39 ` Sudeep Holla
2017-10-10 15:54 ` Sudeep Holla
2017-10-10 17:12 ` Rafael J. Wysocki
2017-10-10 17:13 ` Rafael J. Wysocki
2017-10-10 17:20 ` Sudeep Holla
2017-10-11 4:23 ` Viresh Kumar
2017-10-11 10:11 ` [PATCH v2] PM / OPP: add missing of_node_put() for of_get_cpu_node() Sudeep Holla
2017-10-11 10:21 ` Viresh Kumar
2017-10-11 10:35 ` Sudeep Holla
2017-10-11 10:36 ` Viresh Kumar
2017-10-11 11:21 ` Sudeep Holla
2017-10-11 20:20 ` Stephen Boyd [this message]
2017-10-12 8:50 ` Sudeep Holla
2017-10-12 10:32 ` [PATCH v3] " Sudeep Holla
2017-10-12 20:58 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011202011.GB25302@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.