From: Florian Westphal <fw@strlen.de>
To: Eric Sesterhenn <eric.sesterhenn@x41-dsec.de>
Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org
Subject: Re: [PATCH] Out Of Bound Read in Netfilter Conntrack
Date: Thu, 12 Oct 2017 02:03:46 +0200 [thread overview]
Message-ID: <20171012000346.GE26835@breakpoint.cc> (raw)
In-Reply-To: <804512f5-786b-d4d0-bc8e-299c5c2683bf@x41-dsec.de>
Eric Sesterhenn <eric.sesterhenn@x41-dsec.de> wrote:
> Add missing counter decrement to prevent out of bounds memory read.
>
> Signed-off-by: Eric Sesterhenn <eric.sesterhenn@x41-dsec.de>
>
> diff --git a/net/netfilter/nf_conntrack_h323_asn1.c
> b/net/netfilter/nf_conntrack_h323_asn1.c
> index 89b2e46925c4..2a9d1acd0cbd 100644
> --- a/net/netfilter/nf_conntrack_h323_asn1.c
> +++ b/net/netfilter/nf_conntrack_h323_asn1.c
> @@ -877,6 +877,7 @@ int DecodeQ931(unsigned char *buf, size_t sz, Q931
> *q931)
> if (sz < 1)
> break;
> len = *p++;
> + sz--;
> if (sz < len)
> break;
> p += len;
LGTM.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2017-10-12 0:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 5:01 [PATCH] Out Of Bound Read in Netfilter Conntrack Eric Sesterhenn
2017-10-12 0:03 ` Florian Westphal [this message]
2017-10-13 18:29 ` [PATCH] Bitwise " Eric Sesterhenn
2017-10-17 13:09 ` Pablo Neira Ayuso
2017-10-17 13:48 ` Eric Sesterhenn
2017-10-17 13:53 ` Pablo Neira Ayuso
2017-10-24 16:29 ` [PATCH] " Pablo Neira Ayuso
2017-10-24 16:36 ` Pablo Neira Ayuso
2017-10-25 7:05 ` Eric Sesterhenn
2017-11-06 15:13 ` Pablo Neira Ayuso
2017-11-13 8:09 ` [PATCH 1/2] Convert CHECK_BOUND macro to function eric.sesterhenn
2017-11-13 13:13 ` Pablo Neira Ayuso
2017-11-13 8:09 ` [PATCH 2/2] Extend nf_h323_error_boundary to work on bits as well eric.sesterhenn
2017-11-13 13:14 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012000346.GE26835@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.sesterhenn@x41-dsec.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.