From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Chris Lew <clew@quicinc.com>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
aneela@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
clew@codeaurora.org
Subject: Re: [PATCH v3 1/5] soc: qcom: smem: Use le32_to_cpu for comparison
Date: Wed, 11 Oct 2017 20:54:57 -0700 [thread overview]
Message-ID: <20171012035457.GX1165@minitux> (raw)
In-Reply-To: <1507757350-10508-2-git-send-email-clew@quicinc.com>
On Wed 11 Oct 14:29 PDT 2017, Chris Lew wrote:
> From: Chris Lew <clew@codeaurora.org>
>
> Endianness can vary in the system, add le32_to_cpu when comparing
> partition sizes from smem.
>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> Signed-off-by: Chris Lew <clew@codeaurora.org>
> ---
>
> Changes since v1:
> - New change
>
> Changes since v2:
> - Reduce subject to 50 chars and wrap summary to 72 chars
>
> drivers/soc/qcom/smem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index c28275be0038..db04c45d4132 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -698,7 +698,7 @@ static int qcom_smem_enumerate_partitions(struct qcom_smem *smem,
> return -EINVAL;
> }
>
> - if (header->size != entry->size) {
> + if (le32_to_cpu(header->size) != le32_to_cpu(entry->size)) {
> dev_err(smem->dev,
> "Partition %d has invalid size\n", i);
> return -EINVAL;
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2017-10-12 3:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 21:29 [PATCH v3 0/5] Qualcomm SMEM V12 Support Chris Lew
2017-10-11 21:29 ` [PATCH v3 1/5] soc: qcom: smem: Use le32_to_cpu for comparison Chris Lew
2017-10-12 3:54 ` Bjorn Andersson [this message]
2017-10-11 21:29 ` [PATCH v3 2/5] soc: qcom: smem: Read version from the smem header Chris Lew
2017-10-12 3:56 ` Bjorn Andersson
2017-10-11 21:29 ` [PATCH v3 3/5] soc: qcom: smem: Support global partition Chris Lew
2017-10-12 3:57 ` Bjorn Andersson
2017-10-11 21:29 ` [PATCH v3 4/5] soc: qcom: smem: Support dynamic item limit Chris Lew
2017-10-12 3:58 ` Bjorn Andersson
2017-10-11 21:29 ` [PATCH v3 5/5] soc: qcom: smem: Increase the number of hosts Chris Lew
2017-10-12 3:59 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012035457.GX1165@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=aneela@codeaurora.org \
--cc=clew@codeaurora.org \
--cc=clew@quicinc.com \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.