Re: [Qemu-devel] [PATCH 03/10] migration: Make cache size elements use the right types

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Juan Quintela (quintela@redhat.com) wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  migration/page_cache.c | 8 ++++----
>  migration/page_cache.h | 2 +-
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/migration/page_cache.c b/migration/page_cache.c
> index 381e555ddb..6b2dd77cf0 100644
> --- a/migration/page_cache.c
> +++ b/migration/page_cache.c
> @@ -39,12 +39,12 @@ struct CacheItem {
>  
>  struct PageCache {
>      CacheItem *page_cache;
> -    unsigned int page_size;
> -    int64_t max_num_items;
> -    int64_t num_items;
> +    size_t page_size;
> +    size_t max_num_items;
> +    size_t num_items;
>  };
>  
> -PageCache *cache_init(int64_t num_pages, unsigned int page_size)
> +PageCache *cache_init(size_t num_pages, size_t page_size)
>  {
>      int64_t i;
>  
> diff --git a/migration/page_cache.h b/migration/page_cache.h
> index 4fadd0c501..931868b857 100644
> --- a/migration/page_cache.h
> +++ b/migration/page_cache.h
> @@ -28,7 +28,7 @@ typedef struct PageCache PageCache;
>   * @num_pages: cache maximal number of cached pages
>   * @page_size: cache page size
>   */
> -PageCache *cache_init(int64_t num_pages, unsigned int page_size);
> +PageCache *cache_init(size_t num_pages, size_t page_size);

Makes sense;  have you checked that the build is happy on 32bit
machines with xbzrle_cache_resize still passing an int64_t at this
point?

However, it's the right thing to move to, so:


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>  /**
>   * cache_fini: free all cache resources
> -- 
> 2.13.6
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK