From: Florian Westphal <fw@strlen.de>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] selftests: rtnetlink: add a small macsec test case
Date: Thu, 12 Oct 2017 12:52:16 +0200 [thread overview]
Message-ID: <20171012105216.GF26835@breakpoint.cc> (raw)
In-Reply-To: <20171012101054.GA31183@bistromath.localdomain>
Sabrina Dubroca <sd@queasysnail.net> wrote:
> 2017-10-12, 11:11:22 +0200, Florian Westphal wrote:
> > Signed-off-by: Florian Westphal <fw@strlen.de>
>
> Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Thanks for reviewing.
> Just a small detail: the "ip macsec" commands actually use genetlink
> and not rtnetlink.
Right, but it implements rtnl link ops so it ends up
interacting with rtnetlink too...
I also added sysfs-based change of device aliases to this script,
and I'm sure I will end up adding test cases that interact with
rtnetlink via ioctl, setsockopts and so on.
rtnl_lock() is all over the place so I think it makes sense to
cover as much callsites/call paths as possible even if the entry
point is not via rtnetlink socket.
next prev parent reply other threads:[~2017-10-12 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 9:11 [PATCH net-next] selftests: rtnetlink: add a small macsec test case Florian Westphal
2017-10-12 10:10 ` Sabrina Dubroca
2017-10-12 10:52 ` Florian Westphal [this message]
2017-10-13 6:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012105216.GF26835@breakpoint.cc \
--to=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.