From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753230AbdJLRCx (ORCPT ); Thu, 12 Oct 2017 13:02:53 -0400 Received: from ms.lwn.net ([45.79.88.28]:58094 "EHLO ms.lwn.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751040AbdJLRCv (ORCPT ); Thu, 12 Oct 2017 13:02:51 -0400 Date: Thu, 12 Oct 2017 11:02:49 -0600 From: Jonathan Corbet To: Shuah Khan Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] doc: dev-tools: kselftest.rst: update to include make O=dir support Message-ID: <20171012110249.7d41ff02@lwn.net> In-Reply-To: <20171002234421.20254-1-shuahkh@osg.samsung.com> References: <20171002234421.20254-1-shuahkh@osg.samsung.com> Organization: LWN.net MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Oct 2017 17:44:17 -0600 Shuah Khan wrote: > Update to include details on make O=dir support and other changes improve > test results output. So the three patches you sent me appear to be a part of a larger series that I didn't get. I'll assume you want me to apply these three... > > Signed-off-by: Shuah Khan > --- > Documentation/dev-tools/kselftest.rst | 34 ++++++++++++++++++++++++++++++++-- > 1 file changed, 32 insertions(+), 2 deletions(-) > > diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst > index ebd03d11d2c2..0aa6dde835d1 100644 > --- a/Documentation/dev-tools/kselftest.rst > +++ b/Documentation/dev-tools/kselftest.rst > @@ -31,6 +31,17 @@ To build and run the tests with a single command, use:: > > Note that some tests will require root privileges. > > +Build and run from user specific object directory (make O=dir): > + > + $ make O=/tmp/kselftest kselftest > + > +Build and run KBUILD_OUTPUT directory (make KBUILD_OUTPUT=): > + > + $ make KBUILD_OUTPUT=/tmp/kselftest kselftest > + These lines should really end with a double colon like this: Build and run from user specific object directory (make O=dir):: That indicates that what follows is to be formatted as code, and makes it match the rest of the document. I took the liberty of fixing these up on the way in. All three applied, thanks. jon