From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:39816 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751492AbdJLLp4 (ORCPT ); Thu, 12 Oct 2017 07:45:56 -0400 Date: Thu, 12 Oct 2017 13:46:04 +0200 From: Greg KH To: Luca Coelho Cc: stable@vger.kernel.org, luciano.coelho@intel.com Subject: Re: [PATCH for v4.4] iwlwifi: mvm: use IWL_HCMD_NOCOPY for MCAST_FILTER_CMD Message-ID: <20171012114604.GE32149@kroah.com> References: <150764916163123@kroah.com> <20171011072240.27825-1-luca@coelho.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171011072240.27825-1-luca@coelho.fi> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Oct 11, 2017 at 10:22:40AM +0300, Luca Coelho wrote: > From: Luca Coelho > > commit 97bce57bd7f96e1218751996f549a6e61f18cc8c upstream. > > The MCAST_FILTER_CMD can get quite large when we have many mcast > addresses to set (we support up to 255). So the command should be > send as NOCOPY to prevent a warning caused by too-long commands: > > WARNING: CPU: 0 PID: 9700 at /root/iwlwifi/stack-dev/drivers/net/wireless/intel/iwlwifi/pcie/tx.c:1550 iwl_pcie_enqueue_hcmd+0x8c7/0xb40 [iwlwifi] > Command MCAST_FILTER_CMD (0x1d0) is too large (328 bytes) > > This fixes: https://bugzilla.kernel.org/show_bug.cgi?id=196743 > > Cc: stable@vger.kernel.org > Signed-off-by: Luca Coelho > --- > drivers/net/wireless/iwlwifi/mvm/mac80211.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) Thanks for the patch, now queued up. greg k-h