From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752899AbdJLPiZ (ORCPT ); Thu, 12 Oct 2017 11:38:25 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:57031 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbdJLPiX (ORCPT ); Thu, 12 Oct 2017 11:38:23 -0400 X-Google-Smtp-Source: AOwi7QBKn4TiojmVVQ8JMM3vlAiIDnZ+p6VoHsIhcEMYba8WwFLofGrTvdb7egv4NwLhTaz14YC4tQ== Date: Thu, 12 Oct 2017 08:38:17 -0700 From: Tejun Heo To: Byungchul Park Cc: johannes.berg@intel.com, peterz@infradead.org, mingo@kernel.org, tglx@linutronix.de, oleg@redhat.com, linux-kernel@vger.kernel.org, kernel-team@lge.com Subject: Re: [RESEND PATCH v2 2/2] lockdep: Remove unnecessary acquisitions wrt workqueue flush Message-ID: <20171012153817.GQ3301751@devbig577.frc2.facebook.com> References: <1507618297-27470-1-git-send-email-byungchul.park@lge.com> <1507618297-27470-2-git-send-email-byungchul.park@lge.com> <20171012075435.GK3323@X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171012075435.GK3323@X58A-UD3R> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Oct 12, 2017 at 04:54:35PM +0900, Byungchul Park wrote: > On Tue, Oct 10, 2017 at 03:51:37PM +0900, Byungchul Park wrote: > > The workqueue added manual acquisitions to catch deadlock cases. > > Now crossrelease was introduced, some of those are redundant, since > > wait_for_completion() already includes the acquisition for itself. > > Removed it. > > I think manual annotations for wait_for_completion() should be removed > in this way, since it's already embedded in wait_for_completion(), now. > Don't you think so? As long as we have the same level of protection, simpler code is of course preferable. That said, I haven't followed the discussion closely and don't want to apply it without Peter's ack. Peter? Thanks. -- tejun