From: Roman Gushchin <guro@fb.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: <linux-kernel@vger.kernel.org>, Tejun Heo <tj@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>, Chris Mason <clm@fb.com>,
<kernel-team@fb.com>
Subject: Re: [RFC 1/2] cgroup, kthread: do not allow moving kthreads out of the root cgroup
Date: Thu, 12 Oct 2017 22:47:42 +0100 [thread overview]
Message-ID: <20171012214742.GA18254@castle> (raw)
In-Reply-To: <20171012192445.xdyrueypbncvappq@hirez.programming.kicks-ass.net>
On Thu, Oct 12, 2017 at 09:24:45PM +0200, Peter Zijlstra wrote:
> On Thu, Oct 12, 2017 at 06:37:22PM +0100, Roman Gushchin wrote:
> > Attaching kernel threads to a non-root cgroup is generally a bad
> > idea. Kernel threads are generally performing the work required
> > to keep the system working and healthy, and applying various
> > resource limits may affect system stability and performance.
> >
> > Some examples of dangerous behavior are limiting CPU time available
> > to rcu stuff, memory limits applied to almost all kthreads, etc.
> >
> > To prevent this dangerous behavior, let's deny all kthread
> > movements between cgroups. Right now only kthreads bounded
> > to CPUs are not allowed to move, which is not sufficient.
> >
> > If there are examples of kthreads which can be limited,
> > and it's guaranteed to be safe, we can allow explicit
> > exceptions further.
>
> The traditional use-case is stuffing all the unbound kthreads into a
> system cpuset in order to limit 'crap' on the rest of the CPUs.
> This setup is typically found in HPC and RT environments.
>
> So NAK. This needs to stay working in as far as it still works.
Ok, thanks!
next prev parent reply other threads:[~2017-10-12 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 17:37 [RFC 1/2] cgroup, kthread: do not allow moving kthreads out of the root cgroup Roman Gushchin
2017-10-12 17:37 ` [RFC 2/2] cgroup, kthread: cleanup after sticking kthreads to " Roman Gushchin
2017-10-12 19:24 ` [RFC 1/2] cgroup, kthread: do not allow moving kthreads out of " Peter Zijlstra
2017-10-12 21:47 ` Roman Gushchin [this message]
2017-10-12 21:57 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012214742.GA18254@castle \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.