* [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs
@ 2017-10-12 22:55 Gustavo A. R. Silva
2017-11-03 14:23 ` Herbert Xu
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-10-12 22:55 UTC (permalink / raw)
To: Giovanni Cabiddu, Salvatore Benedetto, Herbert Xu,
David S. Miller
Cc: qat-linux, linux-crypto, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/crypto/qat/qat_common/qat_uclo.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/qat/qat_common/qat_uclo.c b/drivers/crypto/qat/qat_common/qat_uclo.c
index e2454d9..61ae091 100644
--- a/drivers/crypto/qat/qat_common/qat_uclo.c
+++ b/drivers/crypto/qat/qat_common/qat_uclo.c
@@ -791,6 +791,7 @@ static int qat_uclo_init_reg(struct icp_qat_fw_loader_handle *handle,
case ICP_GPA_ABS:
case ICP_GPB_ABS:
ctx_mask = 0;
+ /* fall through */
case ICP_GPA_REL:
case ICP_GPB_REL:
return qat_hal_init_gpr(handle, ae, ctx_mask, reg_type,
@@ -800,6 +801,7 @@ static int qat_uclo_init_reg(struct icp_qat_fw_loader_handle *handle,
case ICP_SR_RD_ABS:
case ICP_DR_RD_ABS:
ctx_mask = 0;
+ /* fall through */
case ICP_SR_REL:
case ICP_DR_REL:
case ICP_SR_RD_REL:
@@ -809,6 +811,7 @@ static int qat_uclo_init_reg(struct icp_qat_fw_loader_handle *handle,
case ICP_SR_WR_ABS:
case ICP_DR_WR_ABS:
ctx_mask = 0;
+ /* fall through */
case ICP_SR_WR_REL:
case ICP_DR_WR_REL:
return qat_hal_init_wr_xfer(handle, ae, ctx_mask, reg_type,
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs
2017-10-12 22:55 [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs Gustavo A. R. Silva
@ 2017-11-03 14:23 ` Herbert Xu
2017-11-03 14:35 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2017-11-03 14:23 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Giovanni Cabiddu, Salvatore Benedetto, David S. Miller, qat-linux,
linux-crypto, linux-kernel
On Thu, Oct 12, 2017 at 05:55:29PM -0500, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs
2017-11-03 14:23 ` Herbert Xu
@ 2017-11-03 14:35 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-11-03 14:35 UTC (permalink / raw)
To: Herbert Xu
Cc: Giovanni Cabiddu, Salvatore Benedetto, David S. Miller, qat-linux,
linux-crypto, linux-kernel
Quoting Herbert Xu <herbert@gondor.apana.org.au>:
> On Thu, Oct 12, 2017 at 05:55:29PM -0500, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>
> Patch applied. Thanks.
Thank you, Herbert.
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-03 14:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-10-12 22:55 [PATCH] crypto: qat: qat_common: qat_uclo - mark expected switch fall-throughs Gustavo A. R. Silva
2017-11-03 14:23 ` Herbert Xu
2017-11-03 14:35 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.