From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] tbb: new package
Date: Thu, 12 Oct 2017 23:21:15 +0200 [thread overview]
Message-ID: <20171012232115.24a8e1d0@windsurf> (raw)
In-Reply-To: <CAPpUvYgu8OqDXqHXr8H_gG3pu2q12fCw94Y9jpcuh+ciVMKE9Q@mail.gmail.com>
Hello,
On Thu, 12 Oct 2017 17:12:49 -0400, Bradford Barr wrote:
> > This patch should be Git formatted and have a proper commit title and
> > description.
>
> As I lifted that patch from Yocto I thought it would be alright. I'll reformat
> and change the commit title and message.
We have stricter requirements than Yocto :)
> > This comment is not in sync with the dependencies of the package: C++,
> > dynamic library, glibc.
> >
>
> Would it be better if I added all the depends from above as part of
> this comment?
You must document all the dependencies in the Config.in comment. See
the Buildroot manual about this.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2017-10-12 21:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 23:50 [Buildroot] [PATCH v2 0/2] TBB and OpenCV3 Bradford Barr
2017-09-28 23:50 ` [Buildroot] [PATCH v2 1/2] tbb: new package Bradford Barr
2017-10-06 16:27 ` Yegor Yefremov
2017-10-12 20:45 ` Thomas Petazzoni
2017-10-12 21:12 ` Bradford Barr
2017-10-12 21:14 ` Bradford Barr
2017-10-12 21:21 ` Thomas Petazzoni [this message]
2017-09-28 23:50 ` [Buildroot] [PATCH v2 2/2] opencv3: add support for tbb Bradford Barr
2017-10-12 20:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012232115.24a8e1d0@windsurf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.