All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chris Brandt <Chris.Brandt@renesas.com>
Subject: Re: [PATCH v6 1/4] cramfs: direct memory access support
Date: Fri, 13 Oct 2017 00:30:22 -0700	[thread overview]
Message-ID: <20171013073022.GI9105@infradead.org> (raw)
In-Reply-To: <20171012061613.28705-2-nicolas.pitre@linaro.org>

This looks much better, thanks.  I'm not a big fan of the games with
IS_ENABLED and letting the compiler optimize code away, but you're
the maintainer..

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chris Brandt <Chris.Brandt@renesas.com>
Subject: Re: [PATCH v6 1/4] cramfs: direct memory access support
Date: Fri, 13 Oct 2017 00:30:22 -0700	[thread overview]
Message-ID: <20171013073022.GI9105@infradead.org> (raw)
In-Reply-To: <20171012061613.28705-2-nicolas.pitre@linaro.org>

This looks much better, thanks.  I'm not a big fan of the games with
IS_ENABLED and letting the compiler optimize code away, but you're
the maintainer..

Reviewed-by: Christoph Hellwig <hch@lst.de>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-10-13  7:30 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12  6:16 [PATCH v6 0/4] cramfs refresh for embedded usage Nicolas Pitre
2017-10-12  6:16 ` Nicolas Pitre
2017-10-12  6:16 ` [PATCH v6 1/4] cramfs: direct memory access support Nicolas Pitre
2017-10-12  6:16   ` Nicolas Pitre
2017-10-12 17:03   ` Chris Brandt
2017-10-12 17:03     ` Chris Brandt
2017-10-13  1:20     ` Nicolas Pitre
2017-10-13  1:20       ` Nicolas Pitre
2017-10-13  7:30   ` Christoph Hellwig [this message]
2017-10-13  7:30     ` Christoph Hellwig
2017-10-13 17:29   ` Al Viro
2017-10-13 17:29     ` Al Viro
2017-10-13 17:39     ` Nicolas Pitre
2017-10-13 17:39       ` Nicolas Pitre
2017-10-13 17:52       ` Al Viro
2017-10-13 17:52         ` Al Viro
2017-10-13 18:18         ` Nicolas Pitre
2017-10-13 18:18           ` Nicolas Pitre
2017-10-13 20:09         ` Nicolas Pitre
2017-10-13 20:09           ` Nicolas Pitre
2017-10-14  0:31           ` Al Viro
2017-10-14  0:31             ` Al Viro
2017-10-14  2:25             ` Nicolas Pitre
2017-10-14  2:25               ` Nicolas Pitre
2017-10-14  2:37               ` Nicolas Pitre
2017-10-14  2:37                 ` Nicolas Pitre
2017-10-12  6:16 ` [PATCH v6 2/4] cramfs: implement uncompressed and arbitrary data block positioning Nicolas Pitre
2017-10-12  6:16   ` Nicolas Pitre
2017-10-12  6:16 ` [PATCH v6 3/4] cramfs: add mmap support Nicolas Pitre
2017-10-12  6:16   ` Nicolas Pitre
2017-10-13  7:31   ` Christoph Hellwig
2017-10-13  7:31     ` Christoph Hellwig
2017-10-12  6:16 ` [PATCH v6 4/4] cramfs: rehabilitate it Nicolas Pitre
2017-10-12  6:16   ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171013073022.GI9105@infradead.org \
    --to=hch@infradead.org \
    --cc=Chris.Brandt@renesas.com \
    --cc=linux-embedded@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nicolas.pitre@linaro.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.