From: Greg KH <gregkh@linuxfoundation.org>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: stable@vger.kernel.org, rostedt@goodmis.org
Subject: Re: [PATCH -stable] rcu: Allow for page faults in NMI handlers
Date: Fri, 13 Oct 2017 11:52:45 +0200 [thread overview]
Message-ID: <20171013095245.GA31636@kroah.com> (raw)
In-Reply-To: <20171012230928.GA31473@linux.vnet.ibm.com>
On Thu, Oct 12, 2017 at 04:09:28PM -0700, Paul E. McKenney wrote:
> A number of architecture invoke rcu_irq_enter() on exception entry in
> order to allow RCU read-side critical sections in the exception handler
> when the exception is from an idle or nohz_full CPU. This works, at
> least unless the exception happens in an NMI handler. In that case,
> rcu_nmi_enter() would already have exited the extended quiescent state,
> which would mean that rcu_irq_enter() would (incorrectly) cause RCU
> to think that it is again in an extended quiescent state. This will
> in turn result in lockdep splats in response to later RCU read-side
> critical sections.
>
> This commit therefore causes rcu_irq_enter() and rcu_irq_exit() to
> take no action if there is an rcu_nmi_enter() in effect, thus avoiding
> the unscheduled return to RCU quiescent state. This in turn should
> make the kernel safe for on-demand RCU voyeurism.
>
> Link: http://lkml.kernel.org/r/20170922211022.GA18084@linux.vnet.ibm.com
>
> Cc: stable@vger.kernel.org # 4.2.x
> Fixes: 0be964be0 ("module: Sanitize RCU usage and locking")
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
This does not apply to the 4.4-stable tree, was this the correct patch I
should be using for that tree?
thanks,
greg k-h
next prev parent reply other threads:[~2017-10-13 9:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 23:09 [PATCH -stable] rcu: Allow for page faults in NMI handlers Paul E. McKenney
2017-10-13 9:52 ` Greg KH [this message]
2017-10-13 16:25 ` Paul E. McKenney
2017-10-13 16:33 ` Greg KH
2017-10-13 16:48 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2017-10-12 23:08 Paul E. McKenney
2017-10-13 9:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171013095245.GA31636@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.