From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell Date: Fri, 13 Oct 2017 18:53:10 +0300 Message-ID: <20171013155310.GD10981@intel.com> References: <20171013154735.27163-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id E7F476E071 for ; Fri, 13 Oct 2017 15:53:14 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20171013154735.27163-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: stable@vger.kernel.org, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBPY3QgMTMsIDIwMTcgYXQgMDQ6NDc6MzVQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IFRoZSBjb21waWxlciB3YXJuczoKPiAKPiAJZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGRpLmM6MTE4OjM1OiB3YXJuaW5nOiDigJhiZHdfZGRpX3RyYW5zbGF0aW9uc19mZGnigJkg ZGVmaW5lZCBidXQgbm90IHVzZWQKPiAKPiBMbyBhbmQgYmVob2xkLCBpZiB3ZSBsb29rIGF0IGlu dGVsX2RkaV9nZXRfYnVmX3RyYW5zX2ZkaSgpLCBpdCB1c2VzCj4gaHN3X2RkaV90cmFuc2xhdGlv bnNfZmRpW10gZm9yIGJvdGggSGFzd2VsbCBhbmQgKkJyb2Fkd2VsbCoKPiAKPiBGaXhlczogN2Qx YzQyZTY3OWY5ICgiZHJtL2k5MTU6IFJlZmFjdG9yIGNvZGUgdG8gc2VsZWN0IHRoZSBEREkgYnVm IHRyYW5zbGF0aW9uIHRhYmxlIikKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlz QGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPiBDYzogRGF2aWQgV2VpbmVoYWxsIDxkYXZpZC53ZWluZWhhbGxA bGludXguaW50ZWwuY29tPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50 ZWwuY29tPgo+IENjOiA8c3RhYmxlQHZnZXIua2VybmVsLm9yZz4gIyB2NC4xMisKClJldmlld2Vk LWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgfCA0ICsrLS0KPiAgMSBmaWxl IGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kZGkuYwo+IGluZGV4IGIzMDdiNmZlMWNlMy4uMTE1MTYyNTQ5OTE0IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtNzM0LDggKzczNCw4IEBAIGludGVsX2RkaV9n ZXRfYnVmX3RyYW5zX2ZkaShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJ CSAgICBpbnQgKm5fZW50cmllcykKPiAgewo+ICAJaWYgKElTX0JST0FEV0VMTChkZXZfcHJpdikp IHsKPiAtCQkqbl9lbnRyaWVzID0gQVJSQVlfU0laRShoc3dfZGRpX3RyYW5zbGF0aW9uc19mZGkp Owo+IC0JCXJldHVybiBoc3dfZGRpX3RyYW5zbGF0aW9uc19mZGk7Cj4gKwkJKm5fZW50cmllcyA9 IEFSUkFZX1NJWkUoYmR3X2RkaV90cmFuc2xhdGlvbnNfZmRpKTsKPiArCQlyZXR1cm4gYmR3X2Rk aV90cmFuc2xhdGlvbnNfZmRpOwo+ICAJfSBlbHNlIGlmIChJU19IQVNXRUxMKGRldl9wcml2KSkg ewo+ICAJCSpuX2VudHJpZXMgPSBBUlJBWV9TSVpFKGhzd19kZGlfdHJhbnNsYXRpb25zX2ZkaSk7 Cj4gIAkJcmV0dXJuIGhzd19kZGlfdHJhbnNsYXRpb25zX2ZkaTsKPiAtLSAKPiAyLjE1LjAucmMw CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:28037 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758329AbdJMPxO (ORCPT ); Fri, 13 Oct 2017 11:53:14 -0400 Date: Fri, 13 Oct 2017 18:53:10 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, David Weinehall , Jani Nikula , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: Use bdw_ddi_translations_fdi for Broadwell Message-ID: <20171013155310.GD10981@intel.com> References: <20171013154735.27163-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171013154735.27163-1-chris@chris-wilson.co.uk> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Oct 13, 2017 at 04:47:35PM +0100, Chris Wilson wrote: > The compiler warns: > > drivers/gpu/drm/i915/intel_ddi.c:118:35: warning: ‘bdw_ddi_translations_fdi’ defined but not used > > Lo and behold, if we look at intel_ddi_get_buf_trans_fdi(), it uses > hsw_ddi_translations_fdi[] for both Haswell and *Broadwell* > > Fixes: 7d1c42e679f9 ("drm/i915: Refactor code to select the DDI buf translation table") > Signed-off-by: Chris Wilson > Cc: Ville Syrjälä > Cc: David Weinehall > Cc: Jani Nikula > Cc: # v4.12+ Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_ddi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c > index b307b6fe1ce3..115162549914 100644 > --- a/drivers/gpu/drm/i915/intel_ddi.c > +++ b/drivers/gpu/drm/i915/intel_ddi.c > @@ -734,8 +734,8 @@ intel_ddi_get_buf_trans_fdi(struct drm_i915_private *dev_priv, > int *n_entries) > { > if (IS_BROADWELL(dev_priv)) { > - *n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi); > - return hsw_ddi_translations_fdi; > + *n_entries = ARRAY_SIZE(bdw_ddi_translations_fdi); > + return bdw_ddi_translations_fdi; > } else if (IS_HASWELL(dev_priv)) { > *n_entries = ARRAY_SIZE(hsw_ddi_translations_fdi); > return hsw_ddi_translations_fdi; > -- > 2.15.0.rc0 -- Ville Syrjälä Intel OTC