All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benoit Parrot <bparrot@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [Patch 2/6] ARM: DRA7: hwmod: Add CAL nodes
Date: Fri, 13 Oct 2017 12:58:17 -0500	[thread overview]
Message-ID: <20171013175817.GG25400@ti.com> (raw)
In-Reply-To: <20171013165654.GK4394@atomide.com>

Tony Lindgren <tony@atomide.com> wrote on Fri [2017-Oct-13 09:56:54 -0700]:
> * Benoit Parrot <bparrot@ti.com> [171012 12:28]:
> > This patch adds the required hwmod nodes to support the Camera
> > Adaptation Layer (CAL) for the DRA72 family of devices.
> ...
> 
> > +static struct omap_hwmod_class_sysconfig dra7xx_cal_sysc = {
> > +	.sysc_offs	= 0x0010,
> 
> Also has .rev_offs at 0 so please add that too.

Ok, I'll add that.

Benoit

> 
> Regards,
> 
> Tony

WARNING: multiple messages have this Message-ID (diff)
From: Benoit Parrot <bparrot@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Tero Kristo <t-kristo@ti.com>, Rob Herring <robh+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-omap@vger.kernel.org>, <linux-media@vger.kernel.org>
Subject: Re: [Patch 2/6] ARM: DRA7: hwmod: Add CAL nodes
Date: Fri, 13 Oct 2017 12:58:17 -0500	[thread overview]
Message-ID: <20171013175817.GG25400@ti.com> (raw)
In-Reply-To: <20171013165654.GK4394@atomide.com>

Tony Lindgren <tony@atomide.com> wrote on Fri [2017-Oct-13 09:56:54 -0700]:
> * Benoit Parrot <bparrot@ti.com> [171012 12:28]:
> > This patch adds the required hwmod nodes to support the Camera
> > Adaptation Layer (CAL) for the DRA72 family of devices.
> ...
> 
> > +static struct omap_hwmod_class_sysconfig dra7xx_cal_sysc = {
> > +	.sysc_offs	= 0x0010,
> 
> Also has .rev_offs at 0 so please add that too.

Ok, I'll add that.

Benoit

> 
> Regards,
> 
> Tony

  reply	other threads:[~2017-10-13 17:58 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-12 19:27 [Patch 0/6] ARM: dts/hwmod: Add CAL and VPE nodes Benoit Parrot
2017-10-12 19:27 ` Benoit Parrot
2017-10-12 19:27 ` [Patch 1/6] ARM: dts: DRA72: Add CAL dtsi node Benoit Parrot
2017-10-12 19:27   ` Benoit Parrot
2017-10-13 16:54   ` Tony Lindgren
     [not found]     ` <20171013165408.GJ4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-13 16:55       ` Benoit Parrot
2017-10-13 16:55         ` Benoit Parrot
2017-10-12 19:27 ` [Patch 2/6] ARM: DRA7: hwmod: Add CAL nodes Benoit Parrot
2017-10-12 19:27   ` Benoit Parrot
     [not found]   ` <20171012192719.15193-3-bparrot-l0cyMroinI0@public.gmane.org>
2017-10-13 16:56     ` Tony Lindgren
2017-10-13 16:56       ` Tony Lindgren
2017-10-13 17:58       ` Benoit Parrot [this message]
2017-10-13 17:58         ` Benoit Parrot
2017-10-12 19:27 ` [Patch 3/6] ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only Benoit Parrot
2017-10-12 19:27   ` Benoit Parrot
2017-10-13 17:01   ` Tony Lindgren
     [not found]     ` <20171013170113.GL4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-13 17:59       ` Benoit Parrot
2017-10-13 17:59         ` Benoit Parrot
2017-10-13 18:03         ` Tony Lindgren
2017-10-12 19:27 ` [Patch 4/6] dt-bindings: media: ti-vpe: Document VPE driver Benoit Parrot
2017-10-12 19:27   ` Benoit Parrot
     [not found]   ` <20171012192719.15193-5-bparrot-l0cyMroinI0@public.gmane.org>
2017-10-17 21:00     ` Rob Herring
2017-10-17 21:00       ` Rob Herring
2017-10-18 13:02       ` Benoit Parrot
2017-10-18 13:02         ` Benoit Parrot
2017-10-19 21:06         ` Rob Herring
2017-10-19 21:20           ` Tony Lindgren
2017-10-12 19:27 ` [Patch 5/6] ARM: DRA7: hwmod: Add VPE nodes Benoit Parrot
2017-10-12 19:27   ` Benoit Parrot
2017-10-13 17:05   ` Tony Lindgren
     [not found]     ` <20171013170513.GM4394-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-10-13 18:05       ` Benoit Parrot
2017-10-13 18:05         ` Benoit Parrot
     [not found]         ` <20171013180534.GI25400-l0cyMroinI0@public.gmane.org>
2017-10-13 19:01           ` Tony Lindgren
2017-10-13 19:01             ` Tony Lindgren
2017-10-12 19:27 ` [Patch 6/6] ARM: dts: dra7: Add VPE dtsi node Benoit Parrot
2017-10-12 19:27   ` Benoit Parrot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171013175817.GG25400@ti.com \
    --to=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.