From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2 9/9] drm/i915: Split intel_enable_ddi()
 into	DP and HDMI variants
Date: Fri, 13 Oct 2017 21:10:23 +0300
Message-ID: <20171013181023.GH10981@intel.com>
References: <20171010121207.570-1-ville.syrjala@linux.intel.com>
 <20171010121207.570-10-ville.syrjala@linux.intel.com>
 <87h8v5o3f4.fsf@intel.com> <87376nku2o.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 01D296EBA1
 for <intel-gfx@lists.freedesktop.org>; Fri, 13 Oct 2017 18:10:27 +0000 (UTC)
Content-Disposition: inline
In-Reply-To: <87376nku2o.fsf@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gRnJpLCBPY3QgMTMsIDIwMTcgYXQgMDU6MjA6NDdQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv
dGU6Cj4gT24gV2VkLCAxMSBPY3QgMjAxNywgSmFuaSBOaWt1bGEgPGphbmkubmlrdWxhQGxpbnV4
LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBUdWUsIDEwIE9jdCAyMDE3LCBWaWxsZSBTeXJqYWxh
IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPj4gRnJvbTogVmlsbGUg
U3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+Pgo+ID4+IFVudGFu
Z2xlIGludGVsX2VuYWJsZV9kZGkoKSBieSBzcGxpdHRpbmcgaXQgaW50byBEUCBhbmQgSERNSSBz
cGVjaWZpYwo+ID4+IHZhcmlhbnRzLgo+ID4+Cj4gPj4gdjI6IEtlZXAgdXNpbmcgaW50ZWxfZGRp
X2dldF9lbmNvZGVyX3BvcnQoKSBmb3Igbm93Cj4gPj4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBWaWxs
ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4+IC0tLQo+ID4+
ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYyB8IDg2ICsrKysrKysrKysrKysrKysr
KysrKysrLS0tLS0tLS0tLS0tLS0tLS0KPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDQ5IGluc2VydGlv
bnMoKyksIDM3IGRlbGV0aW9ucygtKQo+ID4+Cj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX2RkaS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMK
PiA+PiBpbmRleCA0OWNmOGQ5ZDJiYzEuLjE4YmYwNmM3ZTQzZiAxMDA2NDQKPiA+PiAtLS0gYS9k
cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kZGkuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2RkaS5jCj4gPj4gQEAgLTIzNjksNDUgKzIzNjksNTcgQEAgdm9pZCBpbnRl
bF9kZGlfZmRpX3Bvc3RfZGlzYWJsZShzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+
PiAgCUk5MTVfV1JJVEUoRkRJX1JYX0NUTChQSVBFX0EpLCB2YWwpOwo+ID4+ICB9Cj4gPj4gIAo+
ID4+IC1zdGF0aWMgdm9pZCBpbnRlbF9lbmFibGVfZGRpKHN0cnVjdCBpbnRlbF9lbmNvZGVyICpp
bnRlbF9lbmNvZGVyLAo+ID4+IC0JCQkgICAgIGNvbnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl
ICpwaXBlX2NvbmZpZywKPiA+PiArc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX2RkaV9kcChzdHJ1
Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlciwKPiA+PiArCQkJCWNvbnN0IHN0cnVjdCBpbnRlbF9j
cnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ID4+ICsJCQkJY29uc3Qgc3RydWN0IGRybV9jb25uZWN0
b3Jfc3RhdGUgKmNvbm5fc3RhdGUpCj4gPj4gK3sKPiA+PiArCXN0cnVjdCBkcm1faTkxNV9wcml2
YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+ID4+ICsJc3RydWN0
IGludGVsX2RwICppbnRlbF9kcCA9IGVuY190b19pbnRlbF9kcCgmZW5jb2Rlci0+YmFzZSk7Cj4g
Pj4gKwllbnVtIHBvcnQgcG9ydCA9IGludGVsX2RkaV9nZXRfZW5jb2Rlcl9wb3J0KGVuY29kZXIp
Owo+ID4+ICsKPiA+PiArCWlmIChwb3J0ID09IFBPUlRfQSAmJiBJTlRFTF9HRU4oZGV2X3ByaXYp
IDwgOSkKPiA+PiArCQlpbnRlbF9kcF9zdG9wX2xpbmtfdHJhaW4oaW50ZWxfZHApOwo+IAo+IEkg
bm90ZSB0aGF0IHRoaXMgd2FzIG9ubHkgcnVuIG9uIHR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCBw
cmV2aW91c2x5LiBJCj4gc3VwcG9zZSB0aGUgY29uZGl0aW9uIGRvZXMgZWZmZWN0aXZlbHkgaW1w
bHkgZWRwLCBzbyB0aGlzIGlzIHByb2JhYmx5Cj4gZmluZS4KClRoZSBzcGVjIGlzIGFjdHVhbGx5
IGEgbGl0dGxlIHZhZ3VlIHdoaWNoIG9uZSBpdCBtZWFucy4gVGhlIHdvcmRpbmcgdXNlZAppcyAi
SWYgZURQIChEREkgQSksIHNldCBEUF9UUF9DVEwgbGluayB0cmFpbmluZyB0byBOb3JtYWwiLiBT
byBpdCdzIG5vdApjbGVhciBpZiB0aGlzIGNoYW5nZSBpbiBiZWhhdmlvdXIgaXMgcmVxdWlyZWQg
YmVjYXVzZSB0aGUgc2luayBpcyBlRFAsCmJlY2F1c2UgdGhlIGVEUCB0cmFuc2NvZGVyIGlzIHVz
ZWQsIG9yIGJlY2F1c2Ugd2UncmUgZGVhbGluZyB3aXRoIERESSBBLgpTaW5jZSBEREkgQSBpcyBt
ZW50aW9uZWQgSSdtIGdvaW5nIHRvIGFzc3VtZSB0aGF0J3Mgd2hhdCBpdCBtZWFucyA7KQoKPiBJ
dCdzIGp1c3QgdGhhdCBzb21ldGltZXMgSSB3b25kZXIgYWJvdXQgdGhlIGFtb3VudCBvZiBiYWNr
Z3JvdW5kCj4ga25vd2xlZGdlIGxpa2UgdGhpcyB0aGF0IHdlIGltcG9zZSBvbiB0aGUgcmVhZGVy
Lgo+IAo+ID4+ICsKPiA+PiArCWludGVsX2VkcF9iYWNrbGlnaHRfb24oY3J0Y19zdGF0ZSwgY29u
bl9zdGF0ZSk7Cj4gPj4gKwlpbnRlbF9wc3JfZW5hYmxlKGludGVsX2RwLCBjcnRjX3N0YXRlKTsK
PiA+Cj4gPiBUaGlzIGlzIGJyb2tlbiB3aXRob3V0IGVkcCBjaGVjay4KPiAKPiBBbmQgZmluZSBu
b3cgd2l0aCA0ZDkwZjJkNTA3YWIgKCJkcm0vaTkxNTogU3RhcnQgdHJhY2tpbmcgUFNSIHN0YXRl
IGluCj4gY3J0YyBzdGF0ZSIpIG1lcmdlZC4KPiAKPiBSZXZpZXdlZC1ieTogSmFuaSBOaWt1bGEg
PGphbmkubmlrdWxhQGludGVsLmNvbT4KPiAKPiAKPiA+Cj4gPiBCUiwgSmFuaS4KPiA+Cj4gPgo+
ID4+ICsJaW50ZWxfZWRwX2RycnNfZW5hYmxlKGludGVsX2RwLCBjcnRjX3N0YXRlKTsKPiA+PiAr
Cj4gPj4gKwlpZiAoY3J0Y19zdGF0ZS0+aGFzX2F1ZGlvKQo+ID4+ICsJCWludGVsX2F1ZGlvX2Nv
ZGVjX2VuYWJsZShlbmNvZGVyLCBjcnRjX3N0YXRlLCBjb25uX3N0YXRlKTsKPiA+PiArfQo+ID4+
ICsKPiA+PiArc3RhdGljIHZvaWQgaW50ZWxfZW5hYmxlX2RkaV9oZG1pKHN0cnVjdCBpbnRlbF9l
bmNvZGVyICplbmNvZGVyLAo+ID4+ICsJCQkJICBjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0
ZSAqY3J0Y19zdGF0ZSwKPiA+PiArCQkJCSAgY29uc3Qgc3RydWN0IGRybV9jb25uZWN0b3Jfc3Rh
dGUgKmNvbm5fc3RhdGUpCj4gPj4gK3sKPiA+PiArCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiA9IHRvX2k5MTUoZW5jb2Rlci0+YmFzZS5kZXYpOwo+ID4+ICsJc3RydWN0IGludGVs
X2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBlbmNfdG9fZGlnX3BvcnQoJmVuY29kZXItPmJhc2Up
Owo+ID4+ICsJZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kZGlfZ2V0X2VuY29kZXJfcG9ydChlbmNv
ZGVyKTsKPiA+PiArCj4gPj4gKwlpbnRlbF9oZG1pX2hhbmRsZV9zaW5rX3NjcmFtYmxpbmcoZW5j
b2RlciwKPiA+PiArCQkJCQkgIGNvbm5fc3RhdGUtPmNvbm5lY3RvciwKPiA+PiArCQkJCQkgIGNy
dGNfc3RhdGUtPmhkbWlfaGlnaF90bWRzX2Nsb2NrX3JhdGlvLAo+ID4+ICsJCQkJCSAgY3J0Y19z
dGF0ZS0+aGRtaV9zY3JhbWJsaW5nKTsKPiA+PiArCj4gPj4gKwkvKiBJbiBIRE1JL0RWSSBtb2Rl
LCB0aGUgcG9ydCB3aWR0aCwgYW5kIHN3aW5nL2VtcGhhc2lzIHZhbHVlcwo+ID4+ICsJICogYXJl
IGlnbm9yZWQgc28gbm90aGluZyBzcGVjaWFsIG5lZWRzIHRvIGJlIGRvbmUgYmVzaWRlcwo+ID4+
ICsJICogZW5hYmxpbmcgdGhlIHBvcnQuCj4gPj4gKwkgKi8KPiA+PiArCUk5MTVfV1JJVEUoRERJ
X0JVRl9DVEwocG9ydCksCj4gPj4gKwkJICAgZGlnX3BvcnQtPnNhdmVkX3BvcnRfYml0cyB8IERE
SV9CVUZfQ1RMX0VOQUJMRSk7Cj4gPj4gKwo+ID4+ICsJaWYgKGNydGNfc3RhdGUtPmhhc19hdWRp
bykKPiA+PiArCQlpbnRlbF9hdWRpb19jb2RlY19lbmFibGUoZW5jb2RlciwgY3J0Y19zdGF0ZSwg
Y29ubl9zdGF0ZSk7Cj4gPj4gK30KPiA+PiArCj4gPj4gK3N0YXRpYyB2b2lkIGludGVsX2VuYWJs
ZV9kZGkoc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXIsCj4gPj4gKwkJCSAgICAgY29uc3Qg
c3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsCj4gPj4gIAkJCSAgICAgY29uc3Qg
c3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5fc3RhdGUpCj4gPj4gIHsKPiA+PiAtCXN0
cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciA9ICZpbnRlbF9lbmNvZGVyLT5iYXNlOwo+ID4+IC0J
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNvZGVyLT5kZXYp
Owo+ID4+IC0JZW51bSBwb3J0IHBvcnQgPSBpbnRlbF9kZGlfZ2V0X2VuY29kZXJfcG9ydChpbnRl
bF9lbmNvZGVyKTsKPiA+PiAtCWludCB0eXBlID0gaW50ZWxfZW5jb2Rlci0+dHlwZTsKPiA+PiAt
Cj4gPj4gLQlpZiAodHlwZSA9PSBJTlRFTF9PVVRQVVRfSERNSSkgewo+ID4+IC0JCXN0cnVjdCBp
bnRlbF9kaWdpdGFsX3BvcnQgKmludGVsX2RpZ19wb3J0ID0KPiA+PiAtCQkJZW5jX3RvX2RpZ19w
b3J0KGVuY29kZXIpOwo+ID4+IC0JCWJvb2wgY2xvY2tfcmF0aW8gPSBwaXBlX2NvbmZpZy0+aGRt
aV9oaWdoX3RtZHNfY2xvY2tfcmF0aW87Cj4gPj4gLQkJYm9vbCBzY3JhbWJsaW5nID0gcGlwZV9j
b25maWctPmhkbWlfc2NyYW1ibGluZzsKPiA+PiAtCj4gPj4gLQkJaW50ZWxfaGRtaV9oYW5kbGVf
c2lua19zY3JhbWJsaW5nKGludGVsX2VuY29kZXIsCj4gPj4gLQkJCQkJCSAgY29ubl9zdGF0ZS0+
Y29ubmVjdG9yLAo+ID4+IC0JCQkJCQkgIGNsb2NrX3JhdGlvLCBzY3JhbWJsaW5nKTsKPiA+PiAt
Cj4gPj4gLQkJLyogSW4gSERNSS9EVkkgbW9kZSwgdGhlIHBvcnQgd2lkdGgsIGFuZCBzd2luZy9l
bXBoYXNpcyB2YWx1ZXMKPiA+PiAtCQkgKiBhcmUgaWdub3JlZCBzbyBub3RoaW5nIHNwZWNpYWwg
bmVlZHMgdG8gYmUgZG9uZSBiZXNpZGVzCj4gPj4gLQkJICogZW5hYmxpbmcgdGhlIHBvcnQuCj4g
Pj4gLQkJICovCj4gPj4gLQkJSTkxNV9XUklURShERElfQlVGX0NUTChwb3J0KSwKPiA+PiAtCQkJ
ICAgaW50ZWxfZGlnX3BvcnQtPnNhdmVkX3BvcnRfYml0cyB8Cj4gPj4gLQkJCSAgIERESV9CVUZf
Q1RMX0VOQUJMRSk7Cj4gPj4gLQl9IGVsc2UgaWYgKHR5cGUgPT0gSU5URUxfT1VUUFVUX0VEUCkg
ewo+ID4+IC0JCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoZW5j
b2Rlcik7Cj4gPj4gLQo+ID4+IC0JCWlmIChwb3J0ID09IFBPUlRfQSAmJiBJTlRFTF9HRU4oZGV2
X3ByaXYpIDwgOSkKPiA+PiAtCQkJaW50ZWxfZHBfc3RvcF9saW5rX3RyYWluKGludGVsX2RwKTsK
PiA+PiAtCj4gPj4gLQkJaW50ZWxfZWRwX2JhY2tsaWdodF9vbihwaXBlX2NvbmZpZywgY29ubl9z
dGF0ZSk7Cj4gPj4gLQkJaW50ZWxfcHNyX2VuYWJsZShpbnRlbF9kcCwgcGlwZV9jb25maWcpOwo+
ID4+IC0JCWludGVsX2VkcF9kcnJzX2VuYWJsZShpbnRlbF9kcCwgcGlwZV9jb25maWcpOwo+ID4+
IC0JfQo+ID4+IC0KPiA+PiAtCWlmIChwaXBlX2NvbmZpZy0+aGFzX2F1ZGlvKQo+ID4+IC0JCWlu
dGVsX2F1ZGlvX2NvZGVjX2VuYWJsZShpbnRlbF9lbmNvZGVyLCBwaXBlX2NvbmZpZywgY29ubl9z
dGF0ZSk7Cj4gPj4gKwlpZiAoaW50ZWxfY3J0Y19oYXNfdHlwZShjcnRjX3N0YXRlLCBJTlRFTF9P
VVRQVVRfSERNSSkpCj4gPj4gKwkJaW50ZWxfZW5hYmxlX2RkaV9oZG1pKGVuY29kZXIsIGNydGNf
c3RhdGUsIGNvbm5fc3RhdGUpOwo+ID4+ICsJZWxzZQo+ID4+ICsJCWludGVsX2VuYWJsZV9kZGlf
ZHAoZW5jb2RlciwgY3J0Y19zdGF0ZSwgY29ubl9zdGF0ZSk7Cj4gPj4gIH0KPiA+PiAgCj4gPj4g
IHN0YXRpYyB2b2lkIGludGVsX2Rpc2FibGVfZGRpX2RwKHN0cnVjdCBpbnRlbF9lbmNvZGVyICpl
bmNvZGVyLAo+IAo+IC0tIAo+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBUZWNobm9s
b2d5IENlbnRlcgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ
bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au
b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==