All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Aastha Gupta <aastha.gupta4104@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] iptables: iptables-compat translation for TCPMSS
Date: Sun, 15 Oct 2017 13:39:50 +0200	[thread overview]
Message-ID: <20171015113950.GA2233@salvia> (raw)
In-Reply-To: <1508067107-13649-1-git-send-email-aastha.gupta4104@gmail.com>

On Sun, Oct 15, 2017 at 05:01:47PM +0530, Aastha Gupta wrote:
> Since path mtu support was added, we can now add
> iptables-compat translation for TCPMSS extension.
> 
> Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
> ---
>  extensions/libxt_TCPMSS.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/extensions/libxt_TCPMSS.c b/extensions/libxt_TCPMSS.c
> index 4b71e44..7f65298 100644
> --- a/extensions/libxt_TCPMSS.c
> +++ b/extensions/libxt_TCPMSS.c
> @@ -91,6 +91,17 @@ static void TCPMSS_save(const void *ip, const struct xt_entry_target *target)
>  		printf(" --set-mss %u", mssinfo->mss);
>  }
>  
> +static int TCPMSS_xlate(struct xt_xlate *xl,
> +						 const struct xt_xlate_tg_params *params)
> +{
> +	const struct xt_tcpmss_info *mssinfo =
> +		(const struct xt_tcpmss_info *)params->target->data;
> +	if(mssinfo->mss == XT_TCPMSS_CLAMP_PMTU)
> +		xt_xlate_add(xl, "tcp option maxseg size set rt mtu");

Could you also translate other options in man iptables-extensions,
under the TCPMSS target extension?

BTW, please Cc netfilter-devel@vger.kernel.org in your netfilter patches.

Thanks!


      parent reply	other threads:[~2017-10-15 11:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-15 11:31 [PATCH] iptables: iptables-compat translation for TCPMSS Aastha Gupta
2017-10-15 11:36 ` [Outreachy kernel] " Julia Lawall
2017-10-15 11:59   ` Aastha Gupta
2017-10-15 12:08   ` Aastha Gupta
2017-10-15 15:14     ` Julia Lawall
2017-10-15 11:39 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171015113950.GA2233@salvia \
    --to=pablo@netfilter.org \
    --cc=aastha.gupta4104@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.