From: Martin Jansa <martin.jansa@gmail.com>
To: Chen Qi <Qi.Chen@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
Date: Mon, 16 Oct 2017 14:36:51 +0200 [thread overview]
Message-ID: <20171016123651.GA4041@jama> (raw)
In-Reply-To: <0f59f8954cb7e5f1a6709e236249ba60df80aa1d.1508120203.git.Qi.Chen@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 1671 bytes --]
On Mon, Oct 16, 2017 at 10:20:41AM +0800, Chen Qi wrote:
> We changed to make tools required by testimage to be included conditionally.
> This resulted in users who use ssh for git fetching having failures.
>
> Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.
>
> [YOCTO #12227]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
> meta/conf/bitbake.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 0eefb86..2351c66 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -487,7 +487,7 @@ HOSTTOOLS += " \
> HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
>
> # Link to these if present
> -HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
> +HOSTTOOLS_NONFATAL += "ssh aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
Maybe keep the alphabetical order as it was intentionally sorted in:
commit 23dd96a3a175cecde258dc6d8263fbe7b308b58e
Author: Andre McCurdy <armccurdy@gmail.com>
Date: Mon Mar 27 20:51:23 2017 -0700
bitbake.conf: sort HOSTTOOLS and remove duplicates
other than that I'm fine with this.
>
> # Temporary add few more detected in bitbake world
> HOSTTOOLS_NONFATAL += "join nl size yes zcat"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
prev parent reply other threads:[~2017-10-16 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 2:20 [PATCH 0/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL Chen Qi
2017-10-16 2:20 ` [PATCH 1/1] " Chen Qi
2017-10-16 12:36 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016123651.GA4041@jama \
--to=martin.jansa@gmail.com \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.