From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:56948 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752530AbdJPMsv (ORCPT ); Mon, 16 Oct 2017 08:48:51 -0400 Date: Mon, 16 Oct 2017 14:48:59 +0200 From: Greg KH To: Jan Kara Cc: eguan@redhat.com, stable@vger.kernel.org Subject: Re: WTF: patch "[PATCH] quota: Generate warnings for DQUOT_SPACE_NOFAIL allocations" was seriously submitted to be applied to the 4.13-stable tree? Message-ID: <20171016124859.GA23225@kroah.com> References: <150807447357221@kroah.com> <20171016104201.GB9762@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171016104201.GB9762@quack2.suse.cz> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Oct 16, 2017 at 12:42:02PM +0200, Jan Kara wrote: > Hi, > > On Sun 15-10-17 15:34:33, gregkh@linuxfoundation.org wrote: > > The patch below was submitted to be applied to the 4.13-stable tree. > > > > I fail to see how this patch meets the stable kernel rules as found at > > Documentation/process/stable-kernel-rules.rst. > > > > I could be totally wrong, and if so, please respond to > > and let me know why this patch should be > > applied. Otherwise, it is now dropped from my patch queues, never to be > > seen again. > > So I guess your complaint is that the problem is not serious enough to > warrant a stable fix? My thinking was: > > 1) This is a userspace visible regression caused by the below mentioned > commit. > 2) It can result in quota grace times not to be obeyed properly although in > practice it would be hard to come up with a scenario where this would > seriously matter (as they are likely to be setup properly on the next > write). I would like to say I was thinking deep thoughts like this, but what I really was looking at was this in the patch: > > Fixes: 7b9ca4c61bc278b771fb57d6290a31ab1fc7fdac Which showd up in 4.14-rc1, and as such, doesn't make much sense for 4.13-stable :) thanks, greg k-h