From: Riku Voipio <riku.voipio@iki.fi>
To: Laurent Vivier <laurent@vivier.eu>
Cc: Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
pgndev <pgnet.dev@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values
Date: Mon, 16 Oct 2017 13:06:16 +0000 [thread overview]
Message-ID: <20171016130616.GF1918@kos.to> (raw)
In-Reply-To: <c9e56a17-3c75-cfcf-7709-ee27efc291af@vivier.eu>
On Thu, Oct 12, 2017 at 07:08:55PM +0200, Laurent Vivier wrote:
> Le 12/10/2017 à 18:53, Peter Maydell a écrit :
> > On 12 October 2017 at 17:49, Laurent Vivier <laurent@vivier.eu> wrote:
> >> Le 12/10/2017 à 17:30, Peter Maydell a écrit :
> >>> +#if defined(TARGET_SPARC) || defined(TARGET_MIPS)
> >>> +typedef abi_long target_kernel_daddr_t;
> >>> +#else
> >>> +typedef abi_int target_kernel_daddr_t;
> >>> +#endif
> >>
> >> Perhaps you can add these ones into include/exec/user/abitypes.h ?
> >
> > I don't think they belong there -- that file is for basic
> > CPU ABI dependent types, not things which are just part of
> > the kernel interface.
> I agree
So we should go with the patch as-is?
Riku
next prev parent reply other threads:[~2017-10-16 13:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 15:30 [Qemu-devel] [PATCH 0/2] fix incorrect target ioctl numbers Peter Maydell
2017-10-12 15:30 ` [Qemu-devel] [PATCH 1/2] linux-user: Fix target FS_IOC_GETFLAGS and FS_IOC_SETFLAGS numbers Peter Maydell
2017-10-12 16:34 ` Laurent Vivier
2017-10-16 13:05 ` Riku Voipio
2017-10-12 15:30 ` [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values Peter Maydell
2017-10-12 16:49 ` Laurent Vivier
2017-10-12 16:53 ` Peter Maydell
2017-10-12 17:08 ` Laurent Vivier
2017-10-16 13:06 ` Riku Voipio [this message]
2017-10-16 13:09 ` Laurent Vivier
2017-10-16 13:26 ` Peter Maydell
2017-10-16 13:29 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171016130616.GF1918@kos.to \
--to=riku.voipio@iki.fi \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=pgnet.dev@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.