All of lore.kernel.org
 help / color / mirror / Atom feed
From: me@tobin.cc (Tobin C. Harding)
To: kernelnewbies@lists.kernelnewbies.org
Subject: architecture conditional
Date: Tue, 17 Oct 2017 07:36:42 +1100	[thread overview]
Message-ID: <20171016203642.GI16106@eros> (raw)
In-Reply-To: <20171016161053.GA28327@kroah.com>

On Mon, Oct 16, 2017 at 06:10:53PM +0200, Greg KH wrote:
> On Mon, Oct 16, 2017 at 09:37:17PM +1100, Tobin C. Harding wrote:
> > What is the correct way to write code that is conditionally compiled depending on 32/64 bit?
> 
> Not to write code that is dependent on such a thing in the first place
> :)
> 
> > I found
> > 
> > CONFIG_X86_64
> > CONFIG_64BIT
> > 
> > Do we still support other word sizes?
> 
> No, but those are not what you should be looking for, it all depends on
> the architecture and where in the kernel you need to do this (arch
> specific code, driver, kernel, networking, etc.)
> 
> Any specific hints on why you think you need this?

Hashing the kernel pointers. Wanting to call the SipHash functions. We need to call a different
function depending on the size of the pointer.

u64 siphash_1u64(const u64 a, const siphash_key_t *key);
u64 siphash_1u32(const u32 a, const siphash_key_t *key);

Jason A. Donenfeld suggested (offered to) add a helper function in siphash, along the lines of
siphash_1u() but we still need to know the exact size of the return value (so we can drop half of it
if it is 64 bits). We just want a 32 bit identifier returned after hashing the address.

thanks,
Tobin.

  reply	other threads:[~2017-10-16 20:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 10:37 architecture conditional Tobin C. Harding
2017-10-16 16:10 ` Greg KH
2017-10-16 20:36   ` Tobin C. Harding [this message]
2017-10-16 21:09     ` valdis.kletnieks at vt.edu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016203642.GI16106@eros \
    --to=me@tobin.cc \
    --cc=kernelnewbies@lists.kernelnewbies.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.