All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Leon Yang <leon.gh.yang@gmail.com>
Cc: "open list:FILESYSTEMS (VFS and infrastructure)"
	<linux-fsdevel@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Batch unmount cleanup
Date: Mon, 16 Oct 2017 23:19:02 +0100	[thread overview]
Message-ID: <20171016221902.GM21978@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1508179936-15591-1-git-send-email-leon.gh.yang@gmail.com>

On Mon, Oct 16, 2017 at 01:52:16PM -0500, Leon Yang wrote:
> From: Leon Yang <leon.gh.yang@gmail.com>
> 
> Each time the unmounted list is cleanup, synchronize_rcu() is
> called, which is relatively costly. Scheduling the cleanup in a
> workqueue, similar to what is being done in
> net/core/net_namespace.c:cleanup_net, makes unmounting faster
> without adding too much overhead. This is useful especially for
> servers with many containers where mounting/unmounting happens a
> lot.

NAK.  You really do _not_ want to return from umount(2) too early.

  reply	other threads:[~2017-10-16 22:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-16 18:52 [PATCH] Batch unmount cleanup Leon Yang
2017-10-16 22:19 ` Al Viro [this message]
2017-10-18  1:38 ` Eric W. Biederman
2017-10-25 16:20 ` [lkp-robot] c5300ac826: stderr.umount:/tmp/vm-scalability-tmp:target_is_busy kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171016221902.GM21978@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=leon.gh.yang@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.