From: Denys Dmytriyenko <denis@denix.org>
To: Chen Qi <Qi.Chen@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH V2 1/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL
Date: Mon, 16 Oct 2017 22:18:59 -0400 [thread overview]
Message-ID: <20171017021859.GA9221@denix.org> (raw)
In-Reply-To: <97121153b1e6d33790c04c5168dbb5eb8e0e6475.1508204684.git.Qi.Chen@windriver.com>
On Tue, Oct 17, 2017 at 09:46:32AM +0800, Chen Qi wrote:
> We changed to make tools required by testimage to be included conditionally.
> This resulted in users who use ssh for git fetching having failures.
>
> Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.
>
> [YOCTO #12227]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
1. Why don't people specify what has changed between v1 and v2 of the patch?
2. A corrected/sorted patch already went in earlier:
http://cgit.openembedded.org/openembedded-core/commit/?id=50e7619aebae5351e9a41fe1b909a31b9e383f0a
> meta/conf/bitbake.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 0eefb86..4fba9d6 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -487,7 +487,7 @@ HOSTTOOLS += " \
> HOSTTOOLS += "${@['', 'ip ping ps scp ssh stty'][bb.data.inherits_class('testimage', d)]}"
>
> # Link to these if present
> -HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat sudo"
> +HOSTTOOLS_NONFATAL += "aws ccache gcc-ar gpg ld.bfd ld.gold nc sftp socat ssh sudo"
>
> # Temporary add few more detected in bitbake world
> HOSTTOOLS_NONFATAL += "join nl size yes zcat"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2017-10-17 2:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 1:46 [PATCH V2 0/1] bitbake.conf: add ssh to HOSTTOOLS_NONFATAL Chen Qi
2017-10-17 1:46 ` [PATCH V2 1/1] " Chen Qi
2017-10-17 2:18 ` Denys Dmytriyenko [this message]
2017-10-17 2:31 ` ChenQi
2017-10-17 3:05 ` Denys Dmytriyenko
2017-10-17 2:00 ` ✗ patchtest: failure for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017021859.GA9221@denix.org \
--to=denis@denix.org \
--cc=Qi.Chen@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.