From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:42914 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754581AbdJQIfh (ORCPT ); Tue, 17 Oct 2017 04:35:37 -0400 Date: Tue, 17 Oct 2017 10:35:44 +0200 From: Greg Kroah-Hartman To: Alex Manoussakis Cc: stable@vger.kernel.org, Jiri Kosina , Diego Elio Petteo Subject: Re: [PATCH v1] HID: hid-elecom: extend to fix descriptor for HUGE trackball Message-ID: <20171017083544.GA7128@kroah.com> References: <20171016202035.GA5956@gnu.org> <20171017065856.GB24637@kroah.com> <20171017082559.GA19402@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171017082559.GA19402@gnu.org> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Oct 17, 2017 at 04:25:59AM -0400, Alex Manoussakis wrote: > > > * Copyright (c) 2010 Richard Nauber > > > * Copyright (c) 2016 Yuxuan Shui > > > * Copyright (c) 2017 Diego Elio Petten� > > > + * Copyright (c) 2017 Alex Manoussakis > > > > Note, I'm not the maintainer, but you should be aware that adding a line > > like this, with only the changes as expressed in this patch, is very > > dubious according to every lawyer that I know. Please be careful about > > stuff like this, and only add such a line if you really know what you > > are doing[1] > > > > If you have done other changes to this file, my appologies... > > Hi Greg, thanks for the note. The changes I have done is add new USB IDs and > change the text in a couple of places (both comments and messages) to include > the new model "HUGE" where it only said "DEFT". > > We could remove the copyright line I added if it's a problem. I didn't give it > much thought. I copied the linux-input maintainer Jiri, and Diego who added the > code for the DEFT trackballs, in my mainline submission and both were ok > (Diego wrote me "The patch looks good to me", and Jiri submitted it) and now > it's in mainline. Copying Diego in this thread now too. > > My goal is simply to make the trackball I purchased work in my favorite OS, > and benefit other users who have found or will find themselves with a semi- > working device otherwise. And push as far back as 4.4 since some very popular > long-term-support distros use this kernel, I use it too, and it works. > > Can you commit the patch upstream ? Below is the patch that will apply clean > to 4.4 and 4.9, without the extra copyright line if you prefer to use that. > Note 4.4 and 4.9 need to cherry pick 0bb7a37f8d15e5fb5d21776875f9fbc74e10753a > as a prerequisite which adds support for the DEFT trackballs. > > Should I submit a mainline patch that removes the Copyright line I added ? > Let me know what I should do and I'll be happy to do it. Ok, if this is already merged, that's fine, just wanted to point out the obvious copyright statement issues :) I'll add it to my queue of patches to apply to as stable tree after these next kernels get released, thanks. greg k-h