From: Jiri Pirko <jiri@resnulli.us>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>, davem <davem@davemloft.net>
Subject: Re: [PATCH net 0/3] bonding: void calling rtmsg_ifinfo for netlink notifications
Date: Tue, 17 Oct 2017 12:38:06 +0200 [thread overview]
Message-ID: <20171017103806.GG2112@nanopsycho> (raw)
In-Reply-To: <CADvbK_c7R2OJNq=DyXOCSNVzD2aU2qxBO6UiitGbCYS=icwxTQ@mail.gmail.com>
Tue, Oct 17, 2017 at 12:28:45PM CEST, lucien.xin@gmail.com wrote:
>On Tue, Oct 17, 2017 at 5:59 PM, Jiri Pirko <jiri@resnulli.us> wrote:
>> Tue, Oct 17, 2017 at 11:39:38AM CEST, lucien.xin@gmail.com wrote:
>>>It's better to send notifications to userspace by the events
>>>in rtnetlink_event, instead of calling rtmsg_ifinfo directly.
>>>
>>>This patcheset is to remove rtmsg_ifinfo called in bonding,
>>>the notifications can be handled by NETDEV_CHANGEUPPER and
>>>NETDEV_CHANGELOWERSTATE events in rtnetlink_event.
>>>
>>>It could also fix some redundant notifications from bonding.
>>
>> This should go to net-next.
>
>NETDEV_CHANGEUPPER is not yet in rtnetlink_event in net-next tree.
>patches can only work on net tree by now.
>
>Hi, David, you want me to hold them until the patches for NETDEV_CHANGEUPPER
>are copied to net-next, or you would apply them to net ?
This patchset is not fix right? I see no "Fixes" line. You should wait
until the dependency is merged to net-next, rebase, post for net-next.
>
>>
>>
>>>
>>>Xin Long (3):
>>> bonding: remove rtmsg_ifinfo called in bond_master_upper_dev_link
>>> rtnetlink: bring NETDEV_CHANGELOWERSTATE event process back to
>>> rtnetlink_event
>>> bonding: remove rtmsg_ifinfo called after bond_lower_state_changed
>>>
>>> drivers/net/bonding/bond_main.c | 11 +++--------
>>> include/net/bonding.h | 4 ----
>>> net/core/rtnetlink.c | 2 +-
>>> 3 files changed, 4 insertions(+), 13 deletions(-)
>>>
>>>--
>>>2.1.0
>>>
next prev parent reply other threads:[~2017-10-17 10:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 9:39 [PATCH net 0/3] bonding: void calling rtmsg_ifinfo for netlink notifications Xin Long
2017-10-17 9:39 ` [PATCH net 1/3] bonding: remove rtmsg_ifinfo called in bond_master_upper_dev_link Xin Long
2017-10-17 9:39 ` [PATCH net 2/3] rtnetlink: bring NETDEV_CHANGELOWERSTATE event process back to rtnetlink_event Xin Long
2017-10-17 9:39 ` [PATCH net 3/3] bonding: remove rtmsg_ifinfo called after bond_lower_state_changed Xin Long
2017-10-17 9:59 ` [PATCH net 0/3] bonding: void calling rtmsg_ifinfo for netlink notifications Jiri Pirko
2017-10-17 10:28 ` Xin Long
2017-10-17 10:38 ` Jiri Pirko [this message]
2017-10-17 10:48 ` Xin Long
2017-10-19 12:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171017103806.GG2112@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.