All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [libnftnl PATCH v2] expr: Introduce nftnl_expr_fprintf()
Date: Tue, 17 Oct 2017 13:31:50 +0200	[thread overview]
Message-ID: <20171017113150.GA8818@salvia> (raw)
In-Reply-To: <20171017112218.14539-1-phil@nwl.cc>

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

On Tue, Oct 17, 2017 at 01:22:18PM +0200, Phil Sutter wrote:
> Implement expression printing into a FILE pointer analogous to
> nftnl_rule_fprintf().
> 
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> ---
> Changes since v1:
> - Update src/libnftnl.map

Thanks Phil.

I think we need to collapse this change to your patch.

[-- Attachment #2: x.patch --]
[-- Type: text/x-diff, Size: 401 bytes --]

diff --git a/src/libnftnl.map b/src/libnftnl.map
index a01a6599a975..74f33c438a16 100644
--- a/src/libnftnl.map
+++ b/src/libnftnl.map
@@ -103,7 +103,6 @@ global:
   nftnl_expr_get_u64;
   nftnl_expr_get_str;
   nftnl_expr_snprintf;
-  nftnl_expr_fprintf;
   nftnl_expr_free;
 
   nftnl_rule_list_alloc;
@@ -308,3 +307,7 @@ global:
 
 local: *;
 };
+
+LIBNFTNL_6 {
+  nftnl_expr_fprintf;
+} LIBMNL_5;

  reply	other threads:[~2017-10-17 11:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 21:36 [libnftnl PATCH] expr: Introduce nftnl_expr_fprintf() Phil Sutter
2017-10-17 11:05 ` Pablo Neira Ayuso
2017-10-17 11:22   ` [libnftnl PATCH v2] " Phil Sutter
2017-10-17 11:31     ` Pablo Neira Ayuso [this message]
2017-10-17 11:54       ` Phil Sutter
2017-10-17 12:02       ` Phil Sutter
2017-10-17 12:11         ` Pablo Neira Ayuso
2017-10-17 13:17           ` [libnftnl PATCH v3] " Phil Sutter
2017-10-17 13:19             ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017113150.GA8818@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.