Re: [PATCH v2] tests: xlate: print tests passed and error for testfile argument

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Tue, Oct 17, 2017 at 02:44:21PM +0200, Pablo Neira Ayuso wrote:
> On Tue, Oct 17, 2017 at 06:11:20PM +0530, Harsha Sharma wrote:
> > On Tue, Oct 17, 2017 at 4:57 PM, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > On Tue, Oct 17, 2017 at 02:54:58PM +0530, Harsha Sharma wrote:
> > >> Print tests passed with errors and warnings when run with only specified
> > >> test file.
> > >
> > > I would expect this works like this, for consistency with other test
> > > infrastructure we have:
> > >
> > > # python xlate-test.py extensions/libxt_ecn.txlate
> > > Error: test file does not exist
> > >
> > > I can see here this works like this:
> > >
> > > # python xlate-test.py libxt_ecn.txlate
> > >
> > > But as said, it is counterintuitive. Would you revisit this patch?
> > What I have tried to do int this patch is
> > for e.g.
> > 
> > # sudo python xlate-test.py libxt_ecn.txlate
> > will not result into any output as all tests are passed
> > but with this patch
> > # sudo python xlate-test.py libxt_ecn.txlate  (gives output)
> > ## libxt_ecn
> > Ok
> > src: iptables-translate -A INPUT -m ecn --ecn-ip-ect 0
> > res: nft add rule ip filter INPUT ip ecn not-ect counter
> > 
> > Ok
> > src: iptables-translate -A INPUT -m ecn --ecn-ip-ect 1
> > res: nft add rule ip filter INPUT ip ecn ect1 counter
> > 
> > which is expected output as one should get to know if the tests are passed
> > or not .
> >
> > Thanks. Please let me know if this is expected output or not.
> 
> I see, thanks for explaining.
> 
> I would prefer you make this converge with the output of
> iptables-test.py. It would be great if you can update the
> xlate-tests.py so the output looks the same.

If you can fix xlate-tests.py to work with:

# python xlate-test.py extensions/libxt_ecn.txlate

that would be great too :-).