From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PULL 06/36] docker: Enable features explicitly in test-full
Date: Wed, 18 Oct 2017 16:09:47 +0800 [thread overview]
Message-ID: <20171018080947.GC9443@lemon> (raw)
In-Reply-To: <4c054496-5c79-e56f-cd23-4f27694b2934@redhat.com>
On Mon, 10/02 16:21, Paolo Bonzini wrote:
> On 22/09/2017 09:46, Fam Zheng wrote:
> > Also avoid "set -e".
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > Message-Id: <20170907141245.31946-3-famz@redhat.com>
> > Reviewed-by: Eric Blake <eblake@redhat.com>
Sorry for late reply, I've had a backlog due to holiday and KVM Forum.
>
> This broke docker-test-full with at least Fedora and CentOS 6 images. I
> wouldn't be surprised if some required packages do not even exist on
> CentOS 6. Should it be reverted?
Packages not existing on CentOS 6 are supposed to be handled by "FEATURES" in
dockerfile and "requires" in test, but I suspect in this case the method scales,
the list will be cluttered and unmaintainable.
I'll send a reverting patch and continue hoping ./configure to detect features
automatically as before.
Fam
next prev parent reply other threads:[~2017-10-18 8:09 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 7:46 [Qemu-devel] [PULL v5 00/36] Build and test automation patches Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 01/36] docker: ensure NOUSER for travis images Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 02/36] docker: docker.py make --no-cache skip checksum test Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 03/36] docker: don't install device-tree-compiler build-deps in travis.docker Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 04/36] docker: reduce noise when building travis.docker Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 05/36] docker: Update ubuntu image Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 06/36] docker: Enable features explicitly in test-full Fam Zheng
2017-10-02 14:21 ` Paolo Bonzini
2017-10-18 8:09 ` Fam Zheng [this message]
2017-09-22 7:46 ` [Qemu-devel] [PULL 07/36] tests/docker: Clean up paths Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 08/36] docker: Fix return code of build_qemu() Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 09/36] docker: Add test_fail and prep_fail Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 10/36] docker: Use unconfined security profile Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 11/36] docker: Add nettle-devel to fedora image Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 12/36] docker: Add test-block Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 13/36] vl: Don't include vde header Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 14/36] buildsys: Move vde libs to per object Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 15/36] buildsys: Move sdl cflags/libs " Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 16/36] buildsys: Move audio libs " Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 17/36] buildsys: Move libcacard cflags/libs " Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 18/36] buildsys: Move libusb " Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 19/36] buildsys: Move usb redir " Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 20/36] buildsys: Move brlapi libs " Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 21/36] buildsys: Move rdma " Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 22/36] MAINTAINERS: Fix subsystem name for "Build and test automation" Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 23/36] gitignore: Ignore vm test images Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 24/36] qemu.py: Add "wait()" method Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 25/36] scripts: Add archive-source.sh Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 26/36] tests: Add a test key pair Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 27/36] tests: Add vm test lib Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 28/36] tests: Add ubuntu.i386 image Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 29/36] tests: Add FreeBSD image Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 30/36] tests: Add NetBSD image Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 31/36] tests: Add OpenBSD image Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 32/36] Makefile: Add rules to run vm tests Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 33/36] MAINTAINERS: Add tests/vm entry Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 34/36] tests: Add README for vm tests Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 35/36] docker: Use archive-source.py Fam Zheng
2017-09-22 7:46 ` [Qemu-devel] [PULL 36/36] docker: Drop 'set -e' from run script Fam Zheng
2017-09-22 11:55 ` [Qemu-devel] [PULL v5 00/36] Build and test automation patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018080947.GC9443@lemon \
--to=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.