From mboxrd@z Thu Jan 1 00:00:00 1970 From: LW@KARO-electronics.de (Lothar =?UTF-8?B?V2HDn21hbm4=?=) Date: Wed, 18 Oct 2017 08:40:59 +0200 Subject: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property In-Reply-To: <20171018021331.GC18810@dragon> References: <1507719939-27250-1-git-send-email-LW@KARO-electronics.de> <1507719939-27250-4-git-send-email-LW@KARO-electronics.de> <20171016071726.gyzvalxzk4o3jsuz@pengutronix.de> <20171016105632.709e653c@karo-electronics.de> <20171018021331.GC18810@dragon> Message-ID: <20171018084059.022d8116@karo-electronics.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Wed, 18 Oct 2017 10:13:32 +0800 Shawn Guo wrote: > On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Wa?mann wrote: > > Hi, > > > > On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-K?nig wrote: > > > Hello, > > > > > > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Wa?mann wrote: > > > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > > > > index 211e67d..3c852f7 100644 > > > > --- a/arch/arm/boot/dts/imx28-tx28.dts > > > > +++ b/arch/arm/boot/dts/imx28-tx28.dts > > > > @@ -328,8 +328,7 @@ > > > > reg = <0x20>; > > > > pinctrl-names = "default"; > > > > pinctrl-0 = <&tx28_pca9554_pins>; > > > > - interrupt-parent = <&gpio3>; > > > > - interrupts = <28 0>; > > > > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; > > > > gpio-controller; > > > > #gpio-cells = <2>; > > > > interrupt-controller; > > > > > > While interrupts-extended looks nice, > > > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > > has: > > > > > > "interrupts-extended" should only be used when a device has > > > multiple interrupt parents. > > > > > > If this is still true, this patch is wrong. > > > > > Thanks for the hint. It really helps to read the documentation > > sometimes, rahter than relying on existing code only... > > > > A quick check shows, that more than 100 of the 130 uses of > > interrupts-extended are wrong. :( > > So should I drop all interrupts-extended patches from you? > Yes, please. Since this patch, and the corresponding patch for tx53 also fixed the interrupt flags, I will send new patches to only fix the interrupt flags. Lothar Wa?mann From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Date: Wed, 18 Oct 2017 08:40:59 +0200 Message-ID: <20171018084059.022d8116@karo-electronics.de> References: <1507719939-27250-1-git-send-email-LW@KARO-electronics.de> <1507719939-27250-4-git-send-email-LW@KARO-electronics.de> <20171016071726.gyzvalxzk4o3jsuz@pengutronix.de> <20171016105632.709e653c@karo-electronics.de> <20171018021331.GC18810@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20171018021331.GC18810@dragon> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shawn Guo Cc: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Fabio Estevam , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On Wed, 18 Oct 2017 10:13:32 +0800 Shawn Guo wrote: > On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Waßmann wrote: > > Hi, > > > > On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote: > > > Hello, > > > > > > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote: > > > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > > > > index 211e67d..3c852f7 100644 > > > > --- a/arch/arm/boot/dts/imx28-tx28.dts > > > > +++ b/arch/arm/boot/dts/imx28-tx28.dts > > > > @@ -328,8 +328,7 @@ > > > > reg = <0x20>; > > > > pinctrl-names = "default"; > > > > pinctrl-0 = <&tx28_pca9554_pins>; > > > > - interrupt-parent = <&gpio3>; > > > > - interrupts = <28 0>; > > > > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; > > > > gpio-controller; > > > > #gpio-cells = <2>; > > > > interrupt-controller; > > > > > > While interrupts-extended looks nice, > > > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > > has: > > > > > > "interrupts-extended" should only be used when a device has > > > multiple interrupt parents. > > > > > > If this is still true, this patch is wrong. > > > > > Thanks for the hint. It really helps to read the documentation > > sometimes, rahter than relying on existing code only... > > > > A quick check shows, that more than 100 of the 130 uses of > > interrupts-extended are wrong. :( > > So should I drop all interrupts-extended patches from you? > Yes, please. Since this patch, and the corresponding patch for tx53 also fixed the interrupt flags, I will send new patches to only fix the interrupt flags. Lothar Waßmann -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758583AbdJRGlG convert rfc822-to-8bit (ORCPT ); Wed, 18 Oct 2017 02:41:06 -0400 Received: from smtprelay03.ispgateway.de ([80.67.31.30]:36355 "EHLO smtprelay03.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754864AbdJRGlF (ORCPT ); Wed, 18 Oct 2017 02:41:05 -0400 Date: Wed, 18 Oct 2017 08:40:59 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Shawn Guo Cc: Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= , Fabio Estevam , Mark Rutland , Rob Herring , Russell King , Sascha Hauer , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Message-ID: <20171018084059.022d8116@karo-electronics.de> In-Reply-To: <20171018021331.GC18810@dragon> References: <1507719939-27250-1-git-send-email-LW@KARO-electronics.de> <1507719939-27250-4-git-send-email-LW@KARO-electronics.de> <20171016071726.gyzvalxzk4o3jsuz@pengutronix.de> <20171016105632.709e653c@karo-electronics.de> <20171018021331.GC18810@dragon> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kZQ== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, 18 Oct 2017 10:13:32 +0800 Shawn Guo wrote: > On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Waßmann wrote: > > Hi, > > > > On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-König wrote: > > > Hello, > > > > > > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Waßmann wrote: > > > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts > > > > index 211e67d..3c852f7 100644 > > > > --- a/arch/arm/boot/dts/imx28-tx28.dts > > > > +++ b/arch/arm/boot/dts/imx28-tx28.dts > > > > @@ -328,8 +328,7 @@ > > > > reg = <0x20>; > > > > pinctrl-names = "default"; > > > > pinctrl-0 = <&tx28_pca9554_pins>; > > > > - interrupt-parent = <&gpio3>; > > > > - interrupts = <28 0>; > > > > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>; > > > > gpio-controller; > > > > #gpio-cells = <2>; > > > > interrupt-controller; > > > > > > While interrupts-extended looks nice, > > > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > > > has: > > > > > > "interrupts-extended" should only be used when a device has > > > multiple interrupt parents. > > > > > > If this is still true, this patch is wrong. > > > > > Thanks for the hint. It really helps to read the documentation > > sometimes, rahter than relying on existing code only... > > > > A quick check shows, that more than 100 of the 130 uses of > > interrupts-extended are wrong. :( > > So should I drop all interrupts-extended patches from you? > Yes, please. Since this patch, and the corresponding patch for tx53 also fixed the interrupt flags, I will send new patches to only fix the interrupt flags. Lothar Waßmann