From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aastha Gupta <aastha.gupta4104@gmail.com>
Cc: outreachy-kernel@googlegroups.com,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>
Subject: Re: [PATCH v2 00/10] staging: lustre: fix code styling issues and remove macros without users
Date: Wed, 18 Oct 2017 14:26:08 +0200 [thread overview]
Message-ID: <20171018122608.GA3174@kroah.com> (raw)
In-Reply-To: <1507782683-12754-1-git-send-email-aastha.gupta4104@gmail.com>
On Thu, Oct 12, 2017 at 10:01:13AM +0530, Aastha Gupta wrote:
> These patches fix:
> - multi line comment styling
> - line over 80 characters
> - macro definitions warnings by checkpatch.pl
> - drops macros without any users
> - Comparisons should place the constant on the right side
>
> This patch series includes all the patches I sent for this driver to
> show the correct order.
This patch breaks the build in lots of different ways :(
Please ALWAYS test-build your patches before sending them in, otherwise
it makes maintainers really grumpy...
Please fix and resend.
thanks,
greg k-h
next prev parent reply other threads:[~2017-10-18 12:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 4:31 [PATCH v2 00/10] staging: lustre: fix code styling issues and remove macros without users Aastha Gupta
2017-10-12 4:31 ` [PATCH v2 01/10] staging: lustre: fix incorrect multi-line comment style Aastha Gupta
2017-10-17 22:41 ` Dilger, Andreas
2017-10-12 4:31 ` [PATCH v2 02/10] staging: lustre: fix comparisons should place the constant on the right side Aastha Gupta
2017-10-17 22:41 ` Dilger, Andreas
2017-10-12 4:31 ` [PATCH v2 03/10] staging: lustre: fix macro definitions warnings Aastha Gupta
2017-10-17 22:42 ` Dilger, Andreas
2017-10-12 4:31 ` [PATCH v2 04/10] staging: lustre: drop macro that has no uses Aastha Gupta
2017-10-17 22:42 ` Dilger, Andreas
2017-10-12 4:31 ` [PATCH v2 05/10] staging: lustre: fid: fix line over 80 characters Aastha Gupta
2017-10-17 22:43 ` Dilger, Andreas
2017-10-12 4:31 ` [PATCH v2 06/10] staging: lustre: fld: " Aastha Gupta
2017-10-17 22:43 ` Dilger, Andreas
2017-10-12 4:31 ` [PATCH v2 07/10] staging: lustre: ldlm: fix lines over 80 characters in ldlm files Aastha Gupta
2017-10-17 22:52 ` Dilger, Andreas
2017-10-12 4:31 ` [PATCH v2 08/10] staging: lustre: llite: fix lines over 80 characters in llite files Aastha Gupta
2017-10-17 22:54 ` Dilger, Andreas
2017-10-12 4:31 ` [PATCH v2 09/10] staging: lustre: llite: fix coding style for error messages Aastha Gupta
2017-10-17 22:54 ` Dilger, Andreas
2017-10-12 4:31 ` [PATCH v2 10/10] staging: lustre: lllite: fix multi line comments style Aastha Gupta
2017-10-17 22:55 ` Dilger, Andreas
2017-10-18 12:26 ` Greg Kroah-Hartman [this message]
2017-10-18 12:55 ` [PATCH v2 00/10] staging: lustre: fix code styling issues and remove macros without users Aastha Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018122608.GA3174@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aastha.gupta4104@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=jsimmons@infradead.org \
--cc=oleg.drokin@intel.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.