Re: [PATCH v3 03/10] staging: lustre: fix macro definitions warnings

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Wed, Oct 18, 2017 at 05:44:23PM +0530, Aastha Gupta wrote:
> This patch fixes the checkpatch.pl warnings related to macro
> definitions.
> 1. macros with complex values should be enclosed in parentheses.
> 2. macros with multiple lines should be enclosed in do-while block.
> 
> Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
> ---
>  drivers/staging/lustre/lustre/include/lu_object.h | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)

This is the patch that breaks the build, again, always test it before
sending it out.

Here is just one error from the build with this patch enabled, there
were lots and lots of others:

In file included from ./drivers/staging/lustre/lustre/include/lustre_net.h:63:0,
                 from ./drivers/staging/lustre/lustre/include/obd_class.h:37,
                 from drivers/staging/lustre/lustre/osc/osc_dev.c:40:
./drivers/staging/lustre/lustre/include/lu_object.h:1226:1: error: expected identifier or ‘(’ before ‘do’
 do {      \
 ^
drivers/staging/lustre/lustre/osc/osc_dev.c:159:1: note: in expansion of macro ‘LU_TYPE_INIT_FINI’
 LU_TYPE_INIT_FINI(osc, &osc_key, &osc_session_key);
 ^~~~~~~~~~~~~~~~~
./drivers/staging/lustre/lustre/include/lu_object.h:1231:3: error: expected identifier or ‘(’ before ‘while’
 } while (0)
   ^
drivers/staging/lustre/lustre/osc/osc_dev.c:159:1: note: in expansion of macro ‘LU_TYPE_INIT_FINI’
 LU_TYPE_INIT_FINI(osc, &osc_key, &osc_session_key);
 ^~~~~~~~~~~~~~~~~

I've applied the first 2 patches in this series, so please fix and rebase and
resend the rest.

thanks,

greg k-h