Re: [PATCH 3/7] staging: rtl8188eu: use pr_info() instead of printk()

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Thu, Oct 05, 2017 at 06:36:23PM +0530, Aastha Gupta wrote:
> Fixes checkpatch.pl warning:
> WARNING: printk() should include KERN_ facility level
> 
> Replaced printk() without any KERN_facility level with pr_info().
> The statements before use pr_info and the new line character is to be
> appended to them.
> Could have used printk() with KERN_INFO level, but used pr_info() just to use the same function as that had been used before in the code.
> 
> Signed-off-by: Aastha Gupta <aastha.gupta4104@gmail.com>
> ---
>  drivers/staging/rtl8188eu/include/rtw_debug.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/rtw_debug.h b/drivers/staging/rtl8188eu/include/rtw_debug.h
> index 9cc4b8c..33bc7f5 100644
> --- a/drivers/staging/rtl8188eu/include/rtw_debug.h
> +++ b/drivers/staging/rtl8188eu/include/rtw_debug.h
> @@ -106,9 +106,9 @@ extern u32 GlobalDebugLevel;
>  					 (((__i + 1) % 4) == 0) ?	\
>  					 "  " : " ");	\
>  				if (((__i + 1) % 16) == 0)		\
> -					printk("\n");			\
> +					pr_info("\n");			\

No, this isn't doing what you think it is...

It should be a 'pr_cont()', right?

thanks,

greg k-h