All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes
Date: Wed, 18 Oct 2017 18:36:53 +0200	[thread overview]
Message-ID: <20171018163653.GC15371@lunn.ch> (raw)
In-Reply-To: <20171018114458.17891-3-clabbe.montjoie@gmail.com>

> index e1dba9ffa94b..f2292deaa590 100644
> --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> @@ -52,6 +52,7 @@
>  	compatible = "sinovoip,bpi-m2-plus", "allwinner,sun8i-h3";
>  
>  	aliases {
> +		ethernet0 = &emac;
>  		serial0 = &uart0;
>  		serial1 = &uart1;
>  	};
> @@ -111,6 +112,24 @@
>  	status = "okay";
>  };
>  
> +&emac {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&emac_rgmii_pins>;
> +	phy-supply = <&reg_gmac_3v3>;
> +	phy-handle = <&ext_rgmii_phy>;
> +	phy-mode = "rgmii";
> +
> +	allwinner,leds-active-low;
> +	status = "okay";
> +};
> +
> +&external_mdio {
> +	ext_rgmii_phy: ethernet-phy at 1 {
> +		compatible = "ethernet-phy-ieee802.3-c22";
> +		reg = <0>;
> +	};

The reg value should match the @ value.

    Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	f.fainelli@gmail.com, alexandre.torgue@st.com,
	catalin.marinas@arm.com, linux-sunxi@googlegroups.com,
	will.deacon@arm.com, linux@armlinux.org.uk,
	linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org,
	netdev@vger.kernel.org, peppe.cavallaro@st.com,
	maxime.ripard@free-electrons.com, frowand.list@gmail.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes
Date: Wed, 18 Oct 2017 18:36:53 +0200	[thread overview]
Message-ID: <20171018163653.GC15371@lunn.ch> (raw)
In-Reply-To: <20171018114458.17891-3-clabbe.montjoie@gmail.com>

> index e1dba9ffa94b..f2292deaa590 100644
> --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> @@ -52,6 +52,7 @@
>  	compatible = "sinovoip,bpi-m2-plus", "allwinner,sun8i-h3";
>  
>  	aliases {
> +		ethernet0 = &emac;
>  		serial0 = &uart0;
>  		serial1 = &uart1;
>  	};
> @@ -111,6 +112,24 @@
>  	status = "okay";
>  };
>  
> +&emac {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&emac_rgmii_pins>;
> +	phy-supply = <&reg_gmac_3v3>;
> +	phy-handle = <&ext_rgmii_phy>;
> +	phy-mode = "rgmii";
> +
> +	allwinner,leds-active-low;
> +	status = "okay";
> +};
> +
> +&external_mdio {
> +	ext_rgmii_phy: ethernet-phy@1 {
> +		compatible = "ethernet-phy-ieee802.3-c22";
> +		reg = <0>;
> +	};

The reg value should match the @ value.

    Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	maxime.ripard@free-electrons.com, wens@csie.org,
	linux@armlinux.org.uk, catalin.marinas@arm.com,
	will.deacon@arm.com, peppe.cavallaro@st.com,
	alexandre.torgue@st.com, f.fainelli@gmail.com,
	frowand.list@gmail.com, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes
Date: Wed, 18 Oct 2017 18:36:53 +0200	[thread overview]
Message-ID: <20171018163653.GC15371@lunn.ch> (raw)
In-Reply-To: <20171018114458.17891-3-clabbe.montjoie@gmail.com>

> index e1dba9ffa94b..f2292deaa590 100644
> --- a/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> +++ b/arch/arm/boot/dts/sun8i-h3-bananapi-m2-plus.dts
> @@ -52,6 +52,7 @@
>  	compatible = "sinovoip,bpi-m2-plus", "allwinner,sun8i-h3";
>  
>  	aliases {
> +		ethernet0 = &emac;
>  		serial0 = &uart0;
>  		serial1 = &uart1;
>  	};
> @@ -111,6 +112,24 @@
>  	status = "okay";
>  };
>  
> +&emac {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&emac_rgmii_pins>;
> +	phy-supply = <&reg_gmac_3v3>;
> +	phy-handle = <&ext_rgmii_phy>;
> +	phy-mode = "rgmii";
> +
> +	allwinner,leds-active-low;
> +	status = "okay";
> +};
> +
> +&external_mdio {
> +	ext_rgmii_phy: ethernet-phy@1 {
> +		compatible = "ethernet-phy-ieee802.3-c22";
> +		reg = <0>;
> +	};

The reg value should match the @ value.

    Andrew

  reply	other threads:[~2017-10-18 16:36 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-18 11:44 [PATCH v7 00/10] net: stmmac: dwmac-sun8i: Handle integrated PHY Corentin Labbe
2017-10-18 11:44 ` Corentin Labbe
2017-10-18 11:44 ` Corentin Labbe
2017-10-18 11:44 ` [PATCH v7 01/10] dt-bindings: net: Restore sun8i dwmac binding Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44 ` [PATCH v7 02/10] arm: dts: sunxi: Restore EMAC changes Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 16:36   ` Andrew Lunn [this message]
2017-10-18 16:36     ` Andrew Lunn
2017-10-18 16:36     ` Andrew Lunn
2017-10-18 16:44   ` Andrew Lunn
2017-10-18 16:44     ` Andrew Lunn
2017-10-18 16:44     ` Andrew Lunn
2017-10-18 18:50     ` Corentin Labbe
2017-10-18 18:50       ` Corentin Labbe
2017-10-19  6:57       ` Maxime Ripard
2017-10-19  6:57         ` Maxime Ripard
2017-10-19  6:57         ` Maxime Ripard
2017-10-18 11:44 ` [PATCH v7 03/10] arm64: dts: allwinner: " Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44 ` [PATCH v7 04/10] net: stmmac: sun8i: Restore the compatibles Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44 ` [PATCH v7 05/10] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44 ` [PATCH v7 06/10] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44 ` [PATCH v7 07/10] arm64: dts: allwinner: add snps, dwmac-mdio compatible to emac/mdio Corentin Labbe
2017-10-18 11:44   ` [PATCH v7 07/10] arm64: dts: allwinner: add snps,dwmac-mdio " Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44 ` [PATCH v7 08/10] net: stmmac: snps, dwmac-mdio MDIOs are automatically registered Corentin Labbe
2017-10-18 11:44   ` [PATCH v7 08/10] net: stmmac: snps,dwmac-mdio " Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44 ` [PATCH v7 09/10] net: stmmac: dwmac-sun8i: Handle integrated/external MDIOs Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-18 11:44 ` [PATCH v7 10/10] of: mdio: Prevent of_mdiobus_register from scanning mdio-mux nodes Corentin Labbe
2017-10-18 11:44   ` Corentin Labbe
2017-10-24 18:46   ` Rob Herring
2017-10-24 18:46     ` Rob Herring
2017-10-24 19:02     ` Corentin Labbe
2017-10-24 19:02       ` Corentin Labbe
2017-10-24 19:02       ` Corentin Labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171018163653.GC15371@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.