diff for duplicates of <20171018171309.f7idf76ccvofpnpk@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 9e953e4..8a20843 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -6,18 +6,18 @@ On Wed, Oct 18, 2017 at 09:09:48AM -0700, James Bottomley wrote: > > > > > > > > > > > > > > -> > > > > Fixes is only for bug fixes. These don't fix any bugs. +> > > > > Fixes is only for bug fixes. These don't fix any bugs. > > > > > > > > How do you distinguish these in questionable source code > > > > from other error categories or software weaknesses? > > > > > > A style change is one that doesn't change the effect of the > > > execution. -> > > These don't actually even change the assembly, so there's +> > > These don't actually even change the assembly, so there's > > > programmatic > > > proof they're not fixing anything. > > > -> > > Bug means potentially user visible fault. In any bug fix commit +> > > Bug means potentially user visible fault. In any bug fix commit > > > you > > > should document the fault and its effects on users so those > > > backporting @@ -27,16 +27,16 @@ On Wed, Oct 18, 2017 at 09:09:48AM -0700, James Bottomley wrote: > > > > OK, I'll adjust my definition of a bug :-) > -> Subsystems are free to define bugs in any reasonable way. However, +> Subsystems are free to define bugs in any reasonable way. However, > there are two things to note here: > > 1. The style guide is just that, a guide; it's not hard and fast rules. -> That means that violations aren't bugs in the usual sense. -> However, new code should mostly follow it and if it doesn't, there +> That means that violations aren't bugs in the usual sense. +> However, new code should mostly follow it and if it doesn't, there > should be a good reason to go against the guide which should be > explained in the change log. > 2. The coding style evolves, so older drivers usually don't conform. -> Classifying coding style issues as bugs leads to tons of patches +> Classifying coding style issues as bugs leads to tons of patches > "fixing" older drivers, some of which actually end up breaking the > drivers in subtle ways which take ages to be found (at least that's > what we've seen in SCSI). @@ -46,7 +46,3 @@ On Wed, Oct 18, 2017 at 09:09:48AM -0700, James Bottomley wrote: Makes sense. Thanks for verbose explanation. /Jarkko --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 9558f83..fc63a50 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -8,7 +8,7 @@ "ref\01508342988.3958.5.camel@HansenPartnership.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations\0" - "Date\0Wed, 18 Oct 2017 17:13:09 +0000\0" + "Date\0Wed, 18 Oct 2017 20:13:09 +0300\0" "To\0James Bottomley <James.Bottomley@hansenpartnership.com>\0" "Cc\0SF Markus Elfring <elfring@users.sourceforge.net>" Dan Carpenter <dan.carpenter@oracle.com> @@ -37,18 +37,18 @@ "> > > > \n" "> > > > > \n" "> > > > > \n" - "> > > > > Fixes is only for bug fixes.\302\240\302\240These don't fix any bugs.\n" + "> > > > > Fixes is only for bug fixes. These don't fix any bugs.\n" "> > > > \n" "> > > > How do you distinguish these in questionable source code\n" "> > > > from other error categories or software weaknesses?\n" "> > > \n" "> > > A style change is one that doesn't change the effect of the\n" "> > > execution.\n" - "> > > \302\240These don't actually even change the assembly, so there's\n" + "> > > These don't actually even change the assembly, so there's\n" "> > > programmatic\n" "> > > proof they're not fixing anything.\n" "> > > \n" - "> > > Bug means potentially user visible fault. \302\240In any bug fix commit\n" + "> > > Bug means potentially user visible fault. In any bug fix commit\n" "> > > you\n" "> > > should document the fault and its effects on users so those\n" "> > > backporting\n" @@ -58,16 +58,16 @@ "> > \n" "> > OK, I'll adjust my definition of a bug :-)\n" "> \n" - "> Subsystems are free to define bugs in any reasonable way. \302\240However,\n" + "> Subsystems are free to define bugs in any reasonable way. However,\n" "> there are two things to note here:\n" "> \n" "> 1. The style guide is just that, a guide; it's not hard and fast rules.\n" - "> \302\240That means that violations aren't bugs in the usual sense.\n" - "> \302\240However, new code should mostly follow it and if it doesn't, there\n" + "> That means that violations aren't bugs in the usual sense.\n" + "> However, new code should mostly follow it and if it doesn't, there\n" "> should be a good reason to go against the guide which should be\n" "> explained in the change log.\n" "> 2. The coding style evolves, so older drivers usually don't conform.\n" - "> \302\240Classifying coding style issues as bugs leads to tons of patches\n" + "> Classifying coding style issues as bugs leads to tons of patches\n" "> \"fixing\" older drivers, some of which actually end up breaking the\n" "> drivers in subtle ways which take ages to be found (at least that's\n" "> what we've seen in SCSI).\n" @@ -76,10 +76,6 @@ "\n" "Makes sense. Thanks for verbose explanation.\n" "\n" - "/Jarkko\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + /Jarkko -ff10897710029f57af8e82c7b9f9d6d30fcc8883e3894ecc98b80a6904559970 +fe4c7a9ccd0cd0773c809c7046dd918706f00d9266e34cd1cf6761fe2ac9e45c
diff --git a/a/1.txt b/N2/1.txt index 9e953e4..64e4503 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -46,7 +46,3 @@ On Wed, Oct 18, 2017 at 09:09:48AM -0700, James Bottomley wrote: Makes sense. Thanks for verbose explanation. /Jarkko --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 9558f83..aa66566 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -8,7 +8,7 @@ "ref\01508342988.3958.5.camel@HansenPartnership.com\0" "From\0Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>\0" "Subject\0Re: [PATCH 0/4] char-TPM: Adjustments for ten function implementations\0" - "Date\0Wed, 18 Oct 2017 17:13:09 +0000\0" + "Date\0Wed, 18 Oct 2017 20:13:09 +0300\0" "To\0James Bottomley <James.Bottomley@hansenpartnership.com>\0" "Cc\0SF Markus Elfring <elfring@users.sourceforge.net>" Dan Carpenter <dan.carpenter@oracle.com> @@ -76,10 +76,6 @@ "\n" "Makes sense. Thanks for verbose explanation.\n" "\n" - "/Jarkko\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + /Jarkko -ff10897710029f57af8e82c7b9f9d6d30fcc8883e3894ecc98b80a6904559970 +c6f8dbd41d325bc27baf7be4e227e1ad01acbef091b1547083c74cd4e1531650
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.