From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
rel+kernel@agilox.net, stable@vger.kernel.org,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
hpeter+linux_kernel@gmail.com, peter_hong@fintek.com.tw
Subject: Re: [PATCH V1 1/1] serial: 8250_fintek: Fix finding base_port with activated SuperIO
Date: Wed, 18 Oct 2017 21:04:35 +0100 [thread overview]
Message-ID: <20171018210435.576fe152@alans-desktop> (raw)
In-Reply-To: <1508221388-25001-1-git-send-email-hpeter+linux_kernel@gmail.com>
On Tue, 17 Oct 2017 14:23:08 +0800
"Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com> wrote:
> The SuperIO will be configured at boot time by BIOS, but some BIOS
> will not deactivate the SuperIO when the end of configuration. It'll
> lead to mismatch for pdata->base_port in probe_setup_port(). So we'll
> deactivate all SuperIO before activate special base_port in
> fintek_8250_enter_key().
>
> Tested on iBASE MI802.
Good point.
Reviewd-by: Alan Cox <alan@linux.intel.com>
Alan
prev parent reply other threads:[~2017-10-18 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 6:23 [PATCH V1 1/1] serial: 8250_fintek: Fix finding base_port with activated SuperIO Ji-Ze Hong (Peter Hong)
2017-10-18 20:04 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018210435.576fe152@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=rel+kernel@agilox.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.