From mboxrd@z Thu Jan  1 00:00:00 1970
From: hch@lst.de (Christoph Hellwig)
Date: Thu, 19 Oct 2017 12:20:22 +0200
Subject: [PATCH 4.14-rc] nvme-rdma: Fix error status return in tagset
 allocation failure
In-Reply-To: <9604c4ac-0a0f-a029-1894-051e6de50072@grimberg.me>
References: <1508396289-12237-1-git-send-email-sagi@grimberg.me>
 <20171019084926.GA14227@lst.de>
 <9604c4ac-0a0f-a029-1894-051e6de50072@grimberg.me>
Message-ID: <20171019102022.GC17326@lst.de>

>> Can we return an error code instead and just pass in the tag set
>> to be allocated instead of the admin flag?A  E.g.:
>>
>> 	error = nvme_rdma_alloc_tagset(&ctrl->ctrl, &ctrl->ctrl.admin_tagset);
>> 	if (error)
>> 		goto out_free_queue;
>
> We could, but that would mean that the nvme_ctrl tagset pointer will
> need to be updated later (or from the routine itself).

That why I want to pass the address of the tagset pointers, so that
it can be updated.