From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] hmp: Replace error_report_err
Date: Thu, 19 Oct 2017 12:24:56 +0100 [thread overview]
Message-ID: <20171019112456.GG2281@work-vm> (raw)
In-Reply-To: <1508411793-22868-1-git-send-email-lu.zhipeng@zte.com.cn>
* ZhiPeng Lu (lu.zhipeng@zte.com.cn) wrote:
> Use hmp_handle_error instend of error_report_err to set error.
>
> Signed-off-by: ZhiPeng Lu <lu.zhipeng@zte.com.cn>
> Reviewed-by: Jiyun Fan <fan.jiyun@zte.com.cn>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> hmp.c | 26 ++++++++------------------
> 1 file changed, 8 insertions(+), 18 deletions(-)
>
> diff --git a/hmp.c b/hmp.c
> index ec61329..a03bd03 100644
> --- a/hmp.c
> +++ b/hmp.c
> @@ -667,7 +667,7 @@ void hmp_info_vnc(Monitor *mon, const QDict *qdict)
>
> info2l = qmp_query_vnc_servers(&err);
> if (err) {
> - error_report_err(err);
> + hmp_handle_error(mon, &err);
> return;
> }
> if (!info2l) {
> @@ -782,7 +782,7 @@ void hmp_info_balloon(Monitor *mon, const QDict *qdict)
>
> info = qmp_query_balloon(&err);
> if (err) {
> - error_report_err(err);
> + hmp_handle_error(mon, &err);
> return;
> }
>
> @@ -1125,7 +1125,7 @@ void hmp_ringbuf_read(Monitor *mon, const QDict *qdict)
>
> data = qmp_ringbuf_read(chardev, size, false, 0, &err);
> if (err) {
> - error_report_err(err);
> + hmp_handle_error(mon, &err);
> return;
> }
>
> @@ -1192,9 +1192,7 @@ void hmp_balloon(Monitor *mon, const QDict *qdict)
> Error *err = NULL;
>
> qmp_balloon(value, &err);
> - if (err) {
> - error_report_err(err);
> - }
> + hmp_handle_error(mon, &err);
> }
>
> void hmp_block_resize(Monitor *mon, const QDict *qdict)
> @@ -1518,10 +1516,7 @@ void hmp_migrate_set_cache_size(Monitor *mon, const QDict *qdict)
> Error *err = NULL;
>
> qmp_migrate_set_cache_size(value, &err);
> - if (err) {
> - error_report_err(err);
> - return;
> - }
> + hmp_handle_error(mon, &err);
> }
>
> /* Kept for backwards compatibility */
> @@ -1552,10 +1547,7 @@ void hmp_migrate_set_capability(Monitor *mon, const QDict *qdict)
>
> end:
> qapi_free_MigrationCapabilityStatusList(caps);
> -
> - if (err) {
> - error_report_err(err);
> - }
> + hmp_handle_error(mon, &err);
> }
>
> void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
> @@ -1653,9 +1645,7 @@ void hmp_migrate_set_parameter(Monitor *mon, const QDict *qdict)
> cleanup:
> qapi_free_MigrateSetParameters(p);
> visit_free(v);
> - if (err) {
> - error_report_err(err);
> - }
> + hmp_handle_error(mon, &err);
> }
>
> void hmp_client_migrate_info(Monitor *mon, const QDict *qdict)
> @@ -1909,7 +1899,7 @@ void hmp_migrate(Monitor *mon, const QDict *qdict)
>
> qmp_migrate(uri, !!blk, blk, !!inc, inc, false, false, &err);
> if (err) {
> - error_report_err(err);
> + hmp_handle_error(mon, &err);
> return;
> }
>
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2017-10-19 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 11:16 [Qemu-trivial] [PATCH] hmp: Replace error_report_err ZhiPeng Lu
2017-10-19 11:24 ` Dr. David Alan Gilbert [this message]
2017-10-30 3:35 ` Philippe Mathieu-Daudé
2017-10-30 18:31 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019112456.GG2281@work-vm \
--to=dgilbert@redhat.com \
--cc=lu.zhipeng@zte.com.cn \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.