From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:40840 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752797AbdJSMxQ (ORCPT ); Thu, 19 Oct 2017 08:53:16 -0400 Date: Thu, 19 Oct 2017 14:53:23 +0200 From: Greg Kroah-Hartman To: Jiri Kosina Cc: Alex Manoussakis , stable@vger.kernel.org Subject: Re: [PATCH v1] HID: hid-elecom: extend to fix descriptor for HUGE trackball Message-ID: <20171019125323.GA31847@kroah.com> References: <20171016202035.GA5956@gnu.org> <20171019093549.GC20059@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Thu, Oct 19, 2017 at 01:07:25PM +0200, Jiri Kosina wrote: > On Thu, 19 Oct 2017, Greg Kroah-Hartman wrote: > > > > Cc: Greg Kroah-Hartman > > > Cc: # 4.12.x > > > Cc: # 4.9.x: 0bb7a37: HID: elecom: ... DEFT trackballs > > > Cc: # 4.4.x: 0bb7a37: HID: elecom: ... DEFT trackballs > > > > Commit 0bb7a37 is a "new feature", and as such, shouldn't be backported > > to older kernels, right? > > > > I need a very strong agrument from the HID maintainer as to why this > > should be accepted to the older kernels... > > Hi Greg, > > it basically is a new device ID addition (with a small glue code applied > only to that device ID), and as such a left the stable markers there. But > I don't have strong preference either way -- if you feel that this is > beyond the 'new device ID' policy, I wouldn't object strongly. I think it's a bit more than just the normal "add a new id or quirk" logic here. For new devices, it's always best to just update to a newer kernel, there's no reason anyone with these devices should be using 4.9 or older :) thanks, greg k-h