From: Jakub Sitnicki <jkbs@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: "David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, pravin shelar <pshelar@ovn.org>,
Girish Moodalbail <girish.moodalbail@oracle.com>,
Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH net] geneve: Fix function matching VNI and tunnel ID on big-endian
Date: Thu, 19 Oct 2017 14:08:21 +0200 [thread overview]
Message-ID: <20171019140821.0aefacb9@beetle> (raw)
In-Reply-To: <7fb32cd5779c5c0133754194aa6914fa8689853e.1508412016.git.sbrivio@redhat.com>
On Thu, 19 Oct 2017 13:31:28 +0200
Stefano Brivio <sbrivio@redhat.com> wrote:
> On big-endian machines, functions converting between tunnel ID
> and VNI use the three LSBs of tunnel ID storage to map VNI.
>
> The comparison function eq_tun_id_and_vni(), on the other hand,
> attempted to map the VNI from the three MSBs. Fix it by using
> the same check implemented on LE, which maps VNI from the three
> LSBs of tunnel ID.
>
> Fixes: 2e0b26e10352 ("geneve: Optimize geneve device lookup.")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Thanks, Stefano.
Reviewed-by: Jakub Sitnicki <jkbs@redhat.com>
next prev parent reply other threads:[~2017-10-19 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 11:31 [PATCH net] geneve: Fix function matching VNI and tunnel ID on big-endian Stefano Brivio
2017-10-19 12:08 ` Jakub Sitnicki [this message]
2017-10-21 1:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019140821.0aefacb9@beetle \
--to=jkbs@redhat.com \
--cc=davem@davemloft.net \
--cc=girish.moodalbail@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=sbrivio@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.